public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Rahul Rajesh <rajeshrah22@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/NetworkManager] rawhide: Update to 1.57.4 release (development)
Date: Fri, 29 May 2026 12:58:31 +0000 [thread overview]
Message-ID: <rpms-NetworkManager-ac49637ea09c@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/NetworkManager
Branch : rawhide
Commit : ac49637ea09ca8b4d1a3e0e185d60e2c36967881
Author : Rahul Rajesh <rajeshrah22@gmail.com>
Date : 2026-05-28T13:55:00-04:00
Stats : +113/-3 in 5 file(s)
URL : https://src.fedoraproject.org/rpms/NetworkManager/c/ac49637ea09ca8b4d1a3e0e185d60e2c36967881?branch=rawhide
Log:
Update to 1.57.4 release (development)
Also include configuration files for enabling CLAT by default
on Fedora 45
---
diff --git a/.gitignore b/.gitignore
index 140d3db..6f2643e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -456,3 +456,4 @@ network-manager-applet-0.8.1.tar.bz2
prepare_sources_result*/
/NetworkManager-1.56.0.tar.xz
/NetworkManager-1.57.3-dev.tar.xz
+/NetworkManager-1.57.4-dev.tar.xz
diff --git a/0001-nmtui-fix-wrong-use-of-assertions-in-bond-page.patch b/0001-nmtui-fix-wrong-use-of-assertions-in-bond-page.patch
new file mode 100644
index 0000000..a4295f6
--- /dev/null
+++ b/0001-nmtui-fix-wrong-use-of-assertions-in-bond-page.patch
@@ -0,0 +1,65 @@
+From 77c1cf9624e5eb788c47ff3a4feb61f4ed28a48b Mon Sep 17 00:00:00 2001
+From: Beniamino Galvani <bgalvani@redhat.com>
+Date: Wed, 27 May 2026 23:40:31 +0200
+Subject: [PATCH] nmtui: fix wrong use of assertions in bond page
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+When building in release mode the compiler complains with:
+
+ ../src/nmtui/nmt-page-bond.c: In function ‘other_options_widget_changed’:
+ ../src/nmtui/nmt-page-bond.c:373:13: error: ‘name’ may be used uninitialized [-Werror=maybe-uninitialized]
+ 373 | if (_is_other_option(name)) {
+ | ^~~~~~~~~~~~~~~~~~~~~~
+ ../src/nmtui/nmt-page-bond.c:357:25: note: ‘name’ was declared here
+ 357 | const char *name;
+ | ^~~~
+
+That happens because "name" is initialized inside an assertion, which
+is removed in release builds. Assertions must not have side effects.
+
+Move the initialization out of the assertion.
+
+Fixes: 6a841072ec3b ('nmtui/bond: introduce "other options" list')
+---
+ src/nmtui/nmt-page-bond.c | 8 ++++++--
+ 1 file changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/src/nmtui/nmt-page-bond.c b/src/nmtui/nmt-page-bond.c
+index 962a95096b..eeea0b0b73 100644
+--- a/src/nmtui/nmt-page-bond.c
++++ b/src/nmtui/nmt-page-bond.c
+@@ -87,8 +87,10 @@ _bond_update_other_options(NMSettingBond *s_bond, NmtList *list)
+ for (i = 0; i < num_opts; i++) {
+ const char *opt_name;
+ const char *opt_value;
++ gboolean ret;
+
+- nm_assert(nm_setting_bond_get_option(s_bond, i, &opt_name, &opt_value));
++ ret = nm_setting_bond_get_option(s_bond, i, &opt_name, &opt_value);
++ nm_assert(ret);
+
+ if (_is_other_option(opt_name)) {
+ g_ptr_array_add(arr, g_strdup_printf("%s=%s", opt_name, opt_value));
+@@ -355,6 +357,7 @@ other_options_widget_changed(GObject *object, GParamSpec *pspec, gpointer user_d
+ NmtPageBondPrivate *priv = NMT_PAGE_BOND_GET_PRIVATE(bond);
+ gs_strfreev char **other_options = NULL;
+ const char *name;
++ gboolean ret;
+ guint num;
+ guint i;
+
+@@ -368,7 +371,8 @@ other_options_widget_changed(GObject *object, GParamSpec *pspec, gpointer user_d
+ again:
+ num = nm_setting_bond_get_num_options(priv->s_bond);
+ for (i = 0; i < num; i++) {
+- nm_assert(nm_setting_bond_get_option(priv->s_bond, i, &name, NULL));
++ ret = nm_setting_bond_get_option(priv->s_bond, i, &name, NULL);
++ nm_assert(ret);
+
+ if (_is_other_option(name)) {
+ nm_setting_bond_remove_option(priv->s_bond, name);
+--
+2.53.0
+
diff --git a/24-clat-auto.conf b/24-clat-auto.conf
new file mode 100644
index 0000000..668ec04
--- /dev/null
+++ b/24-clat-auto.conf
@@ -0,0 +1,32 @@
+# CLAT implements the client part of 464XLAT (RFC 6877), an
+# architecture that provides IPv4 connectivity to hosts on IPv6-only
+# networks.
+#
+# The default value for the connection property 'ipv4.clat' is still
+# 'no'. Change it globally to 'auto' (1) so that CLAT gets enabled
+# automatically when the network advertises a PREF64 and there is no
+# native IPv4 configured (either because DHCPv4 option 108 was
+# received or because there is no DHCPv4 server).
+#
+# See: https://fedoraproject.org/wiki/Changes/IPv6-Mostly_Support_In_NetworkManager
+
+# Do not modify this file. You can hide/overwrite this file by
+# creating "/etc/NetworkManager/conf.d/24-clat-auto.conf". You can
+# also add configuration snippets with higher priority that override
+# this setting (see `man 5 NetworkManager.conf`). Most importantly,
+# this snippet only sets default values for the profile. You can
+# explicitly set the value for each profile, so that this default
+# value is not used.
+
+# For example, on a particular profile/network set
+#
+# $ nmcli connection modify "$PROFILE" ipv4.clat no
+#
+# to disable CLAT. This prevents the default from this file to take
+# effect.
+
+[connection-24-clat-auto]
+ipv4.clat=1
+
+[.config]
+enable=nm-version-min:1.57
diff --git a/NetworkManager.spec b/NetworkManager.spec
index ada9724..e16d3a7 100644
--- a/NetworkManager.spec
+++ b/NetworkManager.spec
@@ -5,7 +5,7 @@ URL: https://networkmanager.dev/
Group: System Environment/Base
Epoch: 1
-Version: 1.57.3~dev
+Version: 1.57.4~dev
Release: 1%{?dist}
###############################################################################
@@ -162,8 +162,10 @@ Source6: 22-wifi-mac-addr.conf
Source7: 70-nm-connectivity.conf
Source8: readme-ifcfg-rh.txt
Source9: readme-ifcfg-rh-migrated.txt
+Source10: 24-clat-auto.conf
-# Patch1: 0001-example.patch
+# Keep until next rebase
+Patch1: 0001-nmtui-fix-wrong-use-of-assertions-in-bond-page.patch
Requires(post): systemd
Requires(post): systemd-udev
@@ -719,6 +721,9 @@ cp %{SOURCE7} %{buildroot}%{_sysctldir}
%if 0%{?fedora} >= 40
cp %{SOURCE6} %{buildroot}%{nmlibdir}/conf.d/
%endif
+%if 0%{?fedora} >= 45
+cp %{SOURCE10} %{buildroot}%{nmlibdir}/conf.d/
+%endif
%if %{with ifcfg_warning}
cp %{SOURCE8} %{buildroot}%{_sysconfdir}/sysconfig/network-scripts
@@ -868,6 +873,9 @@ fi
%if 0%{?fedora} >= 40
%{nmlibdir}/conf.d/22-wifi-mac-addr.conf
%endif
+%if 0%{?fedora} >= 45
+%{nmlibdir}/conf.d/24-clat-auto.conf
+%endif
%ghost %{_sysconfdir}/%{name}/VPN
%{_bindir}/nm-online
%{_libexecdir}/nm-dhcp-helper
@@ -1065,6 +1073,10 @@ fi
%changelog
+* Wed May 27 2026 Rahul Rajesh <rrajesh@redhat.com> - 1:1.57.4-1
+- Update to 1.57.4 release (development)
+- Enable CLAT config by default for Fedora 45
+
* Tue Mar 31 2026 Íñigo Huguet <ihuguet@redhat.com> - 1:1.57.3-1
- Update to 1.57.3 release (development)
- Enable the CLAT feature
diff --git a/sources b/sources
index f2374b0..400e2b3 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-SHA512 (NetworkManager-1.57.3-dev.tar.xz) = 753b23aa2d7d35b098352df691815ffd8a20394029542c086f787f6b1b1512c52768de958ae7d4e7991492b8433f76b329435bb61b7798ae350fe816c897c399
+SHA512 (NetworkManager-1.57.4-dev.tar.xz) = a6219479ed133a55e3cc207bfad10a8bf54dd74c4d5581dd731f406c46210d35bba497d24adbb05890673e4d14d0f762431a14a5bea2a4c2f79307c55ce62792
reply other threads:[~2026-05-29 12:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rpms-NetworkManager-ac49637ea09c@fedoraproject.org \
--to=rajeshrah22@gmail.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox