public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Milan Bouchet-Valat <nalimilan@club.fr>
To: git-commits@fedoraproject.org
Subject: [rpms/suitesparse] rawhide: Link against correct ILP64 BLAS
Date: Sun, 22 Nov 2026 16:27:43 GMT	[thread overview]
Message-ID: <179536486336.1.8911642622351855449.rpms-suitesparse-6210de5445c9@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/suitesparse
            Branch : rawhide
            Commit : 6210de5445c9a7c5e4d619f2f27c5c832ac6116c
            Author : Milan Bouchet-Valat <nalimilan@club.fr>
            Date   : 2026-11-15T18:15:42+01:00
            Stats  : +3/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/suitesparse/c/6210de5445c9a7c5e4d619f2f27c5c832ac6116c?branch=rawhide

            Log:
            Link against correct ILP64 BLAS

suitesparse64 and suitesparse64_ packages incorrectly linked to libopenblas.so.
Make them link respectively to libflexiblas64.so and libopenblas64_.so.
For clarity and to prevent potential unnoticed changes, explicitly link suitesparse
to libflexiblas.so.

Fixes rhbz#2295952 and rhbz#2506752.
Bug was introduced by e782ba256380c2246ac8af337ff8315cbf07582f.

---
diff --git a/suitesparse.spec b/suitesparse.spec
index ccbe8af..0896303 100644
--- a/suitesparse.spec
+++ b/suitesparse.spec
@@ -286,14 +286,14 @@ do
     # Set flags for ILP64 build
     if [ $build = SuiteSparse64 ]
     then
-       CMAKE_OPTIONS="$CMAKE_OPTIONS -DSUITESPARSE_INCLUDEDIR_POSTFIX=$build -DSUITESPARSE_PKGFILEDIR=%{_libdir}/$build -DCMAKE_RELEASE_POSTFIX=64 -DBLA_VENDOR=OpenBLAS -DALLOW_64BIT_BLAS=yes"
+       CMAKE_OPTIONS="$CMAKE_OPTIONS -DSUITESPARSE_INCLUDEDIR_POSTFIX=$build -DSUITESPARSE_PKGFILEDIR=%{_libdir}/$build -DCMAKE_RELEASE_POSTFIX=64 -DBLA_VENDOR=FlexiBLAS -DSUITESPARSE_USE_64BIT_BLAS=yes -DBLAS_LIBRARIES=%{_libdir}/libflexiblas64.so -DLAPACK_LIBRARIES=%{_libdir}/libflexiblas64.so"
        export CFLAGS="$CFLAGS -DBLAS_OPENBLAS_64"
     elif [ $build = SuiteSparse64_ ]
     then
-       CMAKE_OPTIONS="$CMAKE_OPTIONS -DSUITESPARSE_INCLUDEDIR_POSTFIX=$build -DSUITESPARSE_PKGFILEDIR=%{_libdir}/$build -DCMAKE_RELEASE_POSTFIX=64_ -DBLA_VENDOR=OpenBLAS -DALLOW_64BIT_BLAS=yes -DBLAS_LIBRARIES=%{_libdir}/libopenblas64_.so"
+       CMAKE_OPTIONS="$CMAKE_OPTIONS -DSUITESPARSE_INCLUDEDIR_POSTFIX=$build -DSUITESPARSE_PKGFILEDIR=%{_libdir}/$build -DCMAKE_RELEASE_POSTFIX=64_ -DBLA_VENDOR=OpenBLAS -DSUITESPARSE_USE_64BIT_BLAS=yes -DBLAS64_SUFFIX="_64" -DBLAS_LIBRARIES=%{_libdir}/libopenblas64_.so -DLAPACK_LIBRARIES=%{_libdir}/libopenblas64_.so"
        export CFLAGS="$CFLAGS -DBLAS_OPENBLAS_64"
     else
-       CMAKE_OPTIONS="$CMAKE_OPTIONS -DSUITESPARSE_INCLUDEDIR_POSTFIX=suitesparse -DBLA_VENDOR=FlexiBLAS"
+       CMAKE_OPTIONS="$CMAKE_OPTIONS -DSUITESPARSE_INCLUDEDIR_POSTFIX=suitesparse -DBLA_VENDOR=FlexiBLAS -DBLAS_LIBRARIES=%{_libdir}/libflexiblas.so -DLAPACK_LIBRARIES=%{_libdir}/libflexiblas.so"
     fi   
     %make_build CMAKE_OPTIONS="$CMAKE_OPTIONS" JOBS=%{_smp_build_ncpus}
   popd

                 reply	other threads:[~2026-11-22 16:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179536486336.1.8911642622351855449.rpms-suitesparse-6210de5445c9@fedoraproject.org \
    --to=nalimilan@club.fr \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox