public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jerry James <loganjerry@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/musescore] rawhide: Fix MuseSampler refusing to run in some circumstances
Date: Fri, 20 Nov 2026 16:40:19 GMT	[thread overview]
Message-ID: <179519281915.1.10562078832068798326.rpms-musescore-1deaad4b54ef@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/musescore
Branch : rawhide
Commit : 1deaad4b54efe3cf207efa051a9d01d8a42d1ed3
Author : Jerry James <loganjerry@gmail.com>
Date   : 2026-11-20T09:39:55-07:00
Stats  : +47/-10 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/musescore/c/1deaad4b54efe3cf207efa051a9d01d8a42d1ed3?branch=rawhide

Log:
Fix MuseSampler refusing to run in some circumstances

---
diff --git a/musescore-musesampler-init.patch b/musescore-musesampler-init.patch
new file mode 100644
index 0000000..22d5958
--- /dev/null
+++ b/musescore-musesampler-init.patch
@@ -0,0 +1,30 @@
+--- MuseScore-4.7.7/src/app/main.cpp.orig	2026-11-09 12:48:29.000000000 -0700
++++ MuseScore-4.7.7/src/app/main.cpp	2026-11-20 08:22:29.034456151 -0700
+@@ -36,6 +36,8 @@
+ 
+ #include "log.h"
+ 
++#include <unistd.h>
++
+ #ifndef MUSE_MODULE_DIAGNOSTICS_CRASHPAD_CLIENT
+ static void crashCallback(int signum)
+ {
+@@ -68,6 +70,18 @@ static void app_init_qrc()
+ 
+ int main(int argc, char** argv)
+ {
++    /* MuseSampler contains a function checkWhoCallsMe() that checks whether
++     * argv[0] ends with either "/mscore" or "/MuseScore-4".  If MuseScore is
++     * invoked from a terminal as "mscore" instead of "/usr/bin/mscore", then
++     * checkWhoCallsMe() returns an error and MuseSampler refuses to run.
++     *
++     * We work around the broken checkWhoCallsMe() function by re-executing
++     * with an absolute path in this situation.
++     */
++    if (argv[0][0] != '/') {
++        argv[0] = const_cast<char *>("/usr/bin/mscore");
++        execv("/usr/bin/mscore", argv);
++    }
+ #ifndef MUSE_MODULE_DIAGNOSTICS_CRASHPAD_CLIENT
+     signal(SIGSEGV, crashCallback);
+     signal(SIGILL, crashCallback);

diff --git a/musescore.spec b/musescore.spec
index a885a92..8d457da 100644
--- a/musescore.spec
+++ b/musescore.spec
@@ -14,29 +14,29 @@
 # - Reset to 1 if the version changed
 # - Increase by 1 otherwise
 %global mscore_font_ver           2.003
-%global mscore_font_rel           48%{?dist}
+%global mscore_font_rel           49%{?dist}
 %global mscoretext_font_ver       1.0
-%global mscoretext_font_rel       48%{?dist}
+%global mscoretext_font_rel       49%{?dist}
 %global musescoreicon_font_ver    1.0
-%global musescoreicon_font_rel    48%{?dist}
+%global musescoreicon_font_rel    49%{?dist}
 %global mscorebc_font_ver         1.0
-%global mscorebc_font_rel         48%{?dist}
+%global mscorebc_font_rel         49%{?dist}
 %global mscoretabulature_font_ver 001.000
-%global mscoretabulature_font_rel 48%{?dist}
+%global mscoretabulature_font_rel 49%{?dist}
 %global musejazz_font_ver         1.0
-%global musejazz_font_rel         48%{?dist}
+%global musejazz_font_rel         49%{?dist}
 %global gootville_font_ver        1.3
-%global gootville_font_rel        48%{?dist}
+%global gootville_font_rel        49%{?dist}
 %global gootville_text_font_ver   1.2
-%global gootville_text_font_rel   48%{?dist}
+%global gootville_text_font_rel   49%{?dist}
 %global soundfont_ver             0.2.0
-%global soundfont_rel             48%{?dist}
+%global soundfont_rel             49%{?dist}
 
 Name:           musescore
 Summary:        Music Composition & Notation Software
 Version:        %{musescore_ver}
 # IMPORTANT: Change all the release numbers above, too!
-Release:        1%{?dist}
+Release:        2%{?dist}
 
 # The MuseScore project itself is GPL-3.0-only WITH Font-exception-2.0.  Other
 # licenses in play:
@@ -237,6 +237,10 @@ Patch:          %{name}-CVE-2026-61714.patch
 # Fix build with Qt 6.12
 # https://github.com/musescore/muse_framework/pull/256
 Patch:          %{name}-fix-build-with-qt-6-12.patch
+# Fix MuseSampler refusal to run when invoked as "mscore"
+# See https://github.com/NixOS/nixpkgs/issues/318210#issuecomment-2351919536
+# and https://bugzilla.redhat.com/show_bug.cgi?id=2404987
+Patch:          %{name}-musesampler-init.patch
 
 # See https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
 ExcludeArch:    %{ix86}
@@ -759,6 +763,9 @@ EOF
 %fontfiles -z 9
 
 %changelog
+* Fri Nov 20 2026 Jerry James  <loganjerry@gmail.com> - 4.7.7-2
+- Fix MuseSampler refusing to run in some circumstances
+
 * Thu Nov 12 2026 Jerry James  <loganjerry@gmail.com> - 4.7.7-1
 - Version 4.7.7
 

                 reply	other threads:[~2026-11-20 16:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179519281915.1.10562078832068798326.rpms-musescore-1deaad4b54ef@fedoraproject.org \
    --to=loganjerry@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox