public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Fabian Sauter <fabian.sauter@apsensing.com>
To: git-commits@fedoraproject.org
Subject: [rpms/nginx] f43: Handle missing nginx transaction trigger argument
Date: Fri, 20 Nov 2026 15:07:25 GMT	[thread overview]
Message-ID: <179518724507.1.4589177972807340549.rpms-nginx-3e059ff40c34@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/nginx
            Branch : f43
            Commit : 3e059ff40c343ee3b0726eefee2e690f3f247c1c
            Author : Fabian Sauter <fabian.sauter@apsensing.com>
            Date   : 2026-11-19T15:58:35+01:00
            Stats  : +1/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/nginx/c/3e059ff40c343ee3b0726eefee2e690f3f247c1c?branch=f43

            Log:
            Handle missing nginx transaction trigger argument

Regular RPM transactions pass an installed package count in , so the live upgrade check behaves as before.
rpm-ostree runs the trigger without that argument. Defaulting to 0 skips nginx-upgrade cleanly while preparing the deployment.

Assisted-by: OpenAI Codex

---
diff --git a/nginx.spec b/nginx.spec
index ee738b7..40ee803 100644
--- a/nginx.spec
+++ b/nginx.spec
@@ -510,7 +510,7 @@ install -m 644 -p %{SOURCE20} %{buildroot}%{_tmpfilesdir}/nginx.conf
 # Request zero-downtime upgrade upon installation of a new nginx binary or modules
 # A reload is not sufficient here: https://blog.nginx.org/blog/nginx-dynamic-modules-how-they-work#upgradeMod
 %transfiletriggerin -- %{_sbindir}/nginx %{nginx_moduleconfdir} %{nginx_moduledir}
-if [ $1 -ge 1 ]; then
+if [ "${1:-0}" -ge 1 ]; then
     test -f %{_sysconfdir}/nginx/rpm-disable-upgrade || /usr/bin/nginx-upgrade >/dev/null 2>&1 || :
 fi
 

                 reply	other threads:[~2026-11-20 15:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179518724507.1.4589177972807340549.rpms-nginx-3e059ff40c34@fedoraproject.org \
    --to=fabian.sauter@apsensing.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox