public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Artur Frenszek-Iwicki <fedora@svgames.pl>
To: git-commits@fedoraproject.org
Subject: [rpms/wget2] f44: Backport a patch fixing program crash
Date: Sat, 31 Oct 2026 07:59:25 GMT [thread overview]
Message-ID: <179343356580.1.10103892371479122008.rpms-wget2-e127945e228e@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/wget2
Branch : f44
Commit : e127945e228e0a4292a3f750793f7a10ca734912
Author : Artur Frenszek-Iwicki <fedora@svgames.pl>
Date : 2026-10-31T08:58:36+01:00
Stats : +35/-1 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/wget2/c/e127945e228e0a4292a3f750793f7a10ca734912?branch=f44
Log:
Backport a patch fixing program crash
Solves rhbz#2563343.
---
diff --git a/0001-fix-double-free.patch b/0001-fix-double-free.patch
new file mode 100644
index 0000000..920badd
--- /dev/null
+++ b/0001-fix-double-free.patch
@@ -0,0 +1,27 @@
+From 8d7b977a7dff86e7056fc93b7c73d61779d28cdc Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Tim=20R=C3=BChsen?= <tim.ruehsen@gmx.de>
+Date: Tue, 20 Oct 2026 20:18:51 +0200
+Subject: [PATCH] * src/wget.c (http_send_request): Fix double free
+
+Fixes https://gitlab.com/gnuwget/wget2/-/work_items/729
+---
+ src/wget.c | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/src/wget.c b/src/wget.c
+index fe00c9014..4e2d2e620 100644
+--- a/src/wget.c
++++ b/src/wget.c
+@@ -4512,8 +4512,7 @@ int http_send_request(const wget_iri *iri, const wget_iri *original_url, DOWNLOA
+ wget_http_request_set_free_user_data_cb(req, free_user_data);
+
+ if ((rc = wget_http_send_request(conn, &req)) != WGET_E_SUCCESS) {
+- wget_buffer_free(&context->body);
+- xfree(context);
++ // context has already been freed by free_user_data
+ wget_http_free_request(&req);
+ }
+
+--
+GitLab
+
diff --git a/wget2.spec b/wget2.spec
index c2927e3..9fa187c 100644
--- a/wget2.spec
+++ b/wget2.spec
@@ -8,7 +8,7 @@
Name: wget2
Version: 2.3.0
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: An advanced file and recursive website downloader
# Documentation is GFDL
@@ -23,6 +23,10 @@ Source2: tim.ruehsen-keyring.asc
# Backport from upstream: https://github.com/rockdaboot/wget2/commit/acf7f4ecd35e9d353bfb5d3ad216dd5368f1b3d4
Patch0: 0000-fix-absolute-paths-with-P-option.patch
+# Fix double-free causing a crash (only after failed requests)
+# Backport from upstream: https://gitlab.com/gnuwget/wget2/-/commit/8d7b977a7dff86e7056fc93b7c73d61779d28cdc
+Patch1: 0001-fix-double-free.patch
+
# Buildsystem build requirements
BuildRequires: autoconf
BuildRequires: automake
@@ -183,6 +187,9 @@ echo ".so man1/%{name}.1" > %{buildroot}%{_mandir}/man1/wget.1
%changelog
+* Fri Oct 30 2026 Artur Frenszek-Iwicki <fedora@svgames.pl> - 2.3.0-3
+- Backport a patch fixing program crash after failed request
+
* Fri Oct 23 2026 Artur Frenszek-Iwicki <fedora@svgames.pl> - 2.3.0-2
- Backport fix for using -P with absolute paths (rhbz#2558146)
reply other threads:[~2026-10-31 7:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179343356580.1.10103892371479122008.rpms-wget2-e127945e228e@fedoraproject.org \
--to=fedora@svgames.pl \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox