public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Bradley G Smith <bradley.g.smith@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/runc] f45: Eliminate rpmlint errors and warnings
Date: Sat, 26 Sep 2026 23:17:18 GMT	[thread overview]
Message-ID: <179046463825.1.1581927058742371171.rpms-runc-d414869ed37d@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/runc
            Branch : f45
            Commit : d414869ed37d660c4f9f59a58069c81be5e6c966
            Author : Bradley G Smith <bradley.g.smith@gmail.com>
            Date   : 2026-09-26T15:17:09-07:00
            Stats  : +11/-4 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/runc/c/d414869ed37d660c4f9f59a58069c81be5e6c966?branch=f45

            Log:
            Eliminate rpmlint errors and warnings

- Handle duplicate license files
- Remove shebang from bash completion file

---
diff --git a/runc.spec b/runc.spec
index 68f3abf..f5ad229 100644
--- a/runc.spec
+++ b/runc.spec
@@ -22,13 +22,12 @@ Source0:        %{gosource}
 Source1:        %{archivename}-vendor.tar.bz2
 Source2:        go-vendor-tools.toml
 
+BuildRequires:  fdupes
 BuildRequires:  go-vendor-tools
 BuildRequires:  go-md2man
 BuildRequires:  libpathrs-devel
 BuildRequires:  pkgconfig(libseccomp)
 
-Requires:       libpathrs
-
 Provides:       oci-runtime
 
 Recommends:     container-selinux >= 2:2.85-1
@@ -45,6 +44,10 @@ specification.
 %goprep -p1
 tar -xf %{S:1}
 
+# remove shebang in bash completion file
+%global runccomp ./contrib/completions/bash/runc
+sed -i "1c\\# bash completion for runc                                -*- shell-script -*-" %{runccomp}
+
 %generate_buildrequires
 %go_vendor_license_buildrequires -c %{S:2}
 
@@ -65,9 +68,13 @@ install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
 # install man pages
 install -d -p                           %{buildroot}%{_mandir}/man8
 install -m 0644 -vp man/man8/*.8        %{buildroot}%{_mandir}/man8/.
+
 # install bash completion
-install -m 0755 -vd                     %{buildroot}/%{bash_completions_dir}
-install -m 0644 -vp contrib/completions/bash/%{name} %{buildroot}/%{bash_completions_dir}
+install -d -m 0755                      %{buildroot}%{bash_completions_dir}
+install -D -m 0644 -t                   %{buildroot}%{bash_completions_dir} %{runccomp}
+
+# remove duplicate license files
+%fdupes %{buildroot}%{_datadir}/licenses/runc
 
 %check
 %go_vendor_license_check -c %{S:2}

                 reply	other threads:[~2026-09-26 23:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179046463825.1.1581927058742371171.rpms-runc-d414869ed37d@fedoraproject.org \
    --to=bradley.g.smith@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox