public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
To: git-commits@fedoraproject.org
Subject: [rpms/python-astropy] rawhide: Handle failure on ppc64le
Date: Wed, 23 Sep 2026 21:56:20 GMT [thread overview]
Message-ID: <179020058042.1.75408565189846873.rpms-python-astropy-6770697d82cb@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/python-astropy
Branch : rawhide
Commit : 6770697d82cbe5639855e2bf0bd1a34f88e7c871
Author : Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
Date : 2026-09-21T11:38:28+02:00
Stats : +37/-0 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/python-astropy/c/6770697d82cbe5639855e2bf0bd1a34f88e7c871?branch=rawhide
Log:
Handle failure on ppc64le
---
diff --git a/ppc64le-fix-test_polynomial_poorly_conditioned.patch b/ppc64le-fix-test_polynomial_poorly_conditioned.patch
new file mode 100644
index 0000000..8d9a1c8
--- /dev/null
+++ b/ppc64le-fix-test_polynomial_poorly_conditioned.patch
@@ -0,0 +1,35 @@
+From: Marcin Juszkiewicz <mjuszkiewicz@redhat.com>
+Date: Mon, 21 Sep 2026 12:00:00 +0200
+Subject: [PATCH] Relax tolerance in test_polynomial_poorly_conditioned on ppc64le
+
+The test_polynomial_poorly_conditioned[fixed2-False] test asserts that
+fitted polynomial parameters match the original within atol=1e-14.
+On ppc64le (POWER8+), the linear algebra solver (numpy.linalg.lstsq)
+produces results with sub-display-precision floating-point differences
+that exceed the 1e-14 tolerance. This is caused by fused multiply-add
+(FMA) instructions on POWER which evaluate intermediate expressions at
+higher precision before rounding, changing the final rounding outcome
+compared to x86_64 and aarch64.
+
+Relax the tolerance from 1e-14 to 1e-12 which still verifies 12 digits
+of precision — more than sufficient for a polynomial fitting test.
+
+Assisted-by: LLM
+
+---
+ astropy/modeling/tests/test_fitters.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Index: astropy-8.0.1/astropy/modeling/tests/test_fitters.py
+===================================================================
+--- astropy-8.0.1.orig/astropy/modeling/tests/test_fitters.py
++++ astropy-8.0.1/astropy/modeling/tests/test_fitters.py
+@@ -1105,7 +1105,7 @@ def test_polynomial_poorly_conditioned(f
+ p = fitter(p0, x, y, values)
+ else:
+ p = fitter(p0, x, y, values)
+- assert np.allclose(p0.parameters, p.parameters, rtol=0, atol=1e-14)
++ assert np.allclose(p0.parameters, p.parameters, rtol=0, atol=1e-12)
+
+
+ def test_linear_fitter_with_weights_flat():
diff --git a/python-astropy.spec b/python-astropy.spec
index b7f3bc9..52a3b79 100644
--- a/python-astropy.spec
+++ b/python-astropy.spec
@@ -20,6 +20,8 @@ Patch: python-astropy-system-configobj.patch
Patch: fix-doctest.patch
# Handle dividing by zero differences
Patch: riscv-fix-test_freedman_bin_width.patch
+# Handle FMA precision differences on ppc64le
+Patch: ppc64le-fix-test_polynomial_poorly_conditioned.patch
BuildRequires: gcc
BuildRequires: expat-devel
reply other threads:[~2026-09-23 21:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179020058042.1.75408565189846873.rpms-python-astropy-6770697d82cb@fedoraproject.org \
--to=marcin@juszkiewicz.com.pl \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox