public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Martin Stransky <stransky@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/firefox] f45: Merge branch 'main' into f45
Date: Wed, 23 Sep 2026 08:30:54 GMT [thread overview]
Message-ID: <179015225474.1.13630579017834791692.rpms-firefox-c90c44c6430a@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/firefox
Branch : f45
Commit : c90c44c6430a89dc8f5369e737e1f9e7c6006efd
Author : Martin Stransky <stransky@redhat.com>
Date : 2026-09-23T10:05:35+02:00
Stats : +41/-0 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/firefox/c/c90c44c6430a89dc8f5369e737e1f9e7c6006efd?branch=f45
Log:
Merge branch 'main' into f45
---
diff --git a/firefox-update.sh b/firefox-update.sh
index de1c437..b72b1a0 100755
--- a/firefox-update.sh
+++ b/firefox-update.sh
@@ -344,6 +344,44 @@ show_local_changes() {
return 0
}
+# Prints the diff that is about to be committed. Rebased patch files can make
+# it huge, so anything longer than $DIFF_PREVIEW_LINES is only shown on request.
+DIFF_PREVIEW_LINES=500
+
+show_staged_diff() {
+ if git diff --cached --quiet; then
+ warn "Nothing is staged - there is no diff to review."
+ return 1
+ fi
+
+ printf '\n%sDiff to be committed:%s\n\n' "$C_BOLD$C_YELLOW" "$C_OFF"
+ git --no-pager diff --cached --stat
+
+ local lines
+ lines=$(git --no-pager diff --cached | wc -l)
+ printf '\n'
+ if [ "$lines" -le "$DIFF_PREVIEW_LINES" ]; then
+ git --no-pager diff --cached
+ else
+ info "The diff has $lines lines."
+ if confirm "Show the full diff?"; then
+ git --no-pager diff --cached
+ else
+ info "Skipped; review it later with 'git diff --cached'."
+ fi
+ fi
+
+ # Changes left out of the commit are easy to miss once fedpkg opens $EDITOR.
+ if ! git diff --quiet; then
+ printf '\n'
+ warn "These tracked files are modified but NOT staged:"
+ git --no-pager diff --name-only | sed 's/^/ /' >&2
+ fi
+
+ printf '\n'
+ return 0
+}
+
# Destructive prompts are never auto-answered by --yes; they always need a
# deliberate keystroke. Answering 'q' aborts the whole update.
confirm_destructive() {
@@ -863,6 +901,9 @@ if ! skip_step 13; then
printf '\n%sStaged changes:%s\n' "$C_BOLD" "$C_OFF"
git status --short --untracked-files=no
+ show_staged_diff
+ confirm "Commit these changes?" y || die "Commit cancelled - the changes stay staged"
+
run fedpkg commit -c || die "fedpkg commit failed"
ok "Committed: $(git log -1 --pretty=%s)"
fi
next reply other threads:[~2026-09-23 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 8:30 Martin Stransky [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-23 8:01 [rpms/firefox] f45: Merge branch 'main' into f45 Martin Stransky
2026-09-17 12:00 Martin Stransky
2026-09-15 3:00 Martin Stransky
2026-09-07 8:03 Martin Stransky
2026-09-01 9:03 Martin Stransky
2026-09-01 6:11 Martin Stransky
2026-08-31 17:45 Martin Stransky
2026-08-31 8:32 Martin Stransky
2026-08-27 16:00 Martin Stransky
2026-08-26 12:04 Martin Stransky
2026-08-24 9:45 Martin Stransky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179015225474.1.13630579017834791692.rpms-firefox-c90c44c6430a@fedoraproject.org \
--to=stransky@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox