public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Martin Osvald <mosvald@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/dhcpcd] rawhide: Add rpminspect.yaml to ignore inet_aton() and inet_ntoa()
Date: Wed, 23 Sep 2026 07:11:20 GMT	[thread overview]
Message-ID: <179014748000.1.3022067110823676828.rpms-dhcpcd-fd8e8a25d067@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/dhcpcd
Branch : rawhide
Commit : fd8e8a25d0679cc1b73950426481fdcdd0477b6c
Author : Martin Osvald <mosvald@redhat.com>
Date   : 2026-07-27T10:28:18+02:00
Stats  : +13/-0 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/dhcpcd/c/fd8e8a25d0679cc1b73950426481fdcdd0477b6c?branch=rawhide

Log:
Add rpminspect.yaml to ignore inet_aton() and inet_ntoa()

---
diff --git a/rpminspect.yaml b/rpminspect.yaml
new file mode 100644
index 0000000..da14b0e
--- /dev/null
+++ b/rpminspect.yaml
@@ -0,0 +1,13 @@
+---
+badfuncs:
+  allowed:
+# This is a rpminspect false positive. Both functions are deprecated in favor of inet_pton/inet_ntop,
+# but there is no exploitable security issue in dhcpcd's specific usage:
+# - inet_aton() only parses trusted admin config; error returns are checked.
+# - inet_ntoa() is used in a single-threaded context with no double-evaluation in any single format call.
+# Fixing it would require patching ~40 call sites in the upstream source to use inet_ntop(AF_INET, ...)
+# with a local buffer, which is a cosmetic/correctness improvement, not a security fix.
+    /usr/bin/dhcpcd:
+      - inet_aton
+      - inet_ntoa
+

                 reply	other threads:[~2026-09-23  7:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179014748000.1.3022067110823676828.rpms-dhcpcd-fd8e8a25d067@fedoraproject.org \
    --to=mosvald@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox