public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Mamoru TASAKA <mtasaka@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/rubygem-cookiejar] rawhide: Skip some tests which depends on options removed on json 3
Date: Mon, 21 Sep 2026 07:16:24 GMT	[thread overview]
Message-ID: <178997498435.1.18237246929004298813.rpms-rubygem-cookiejar-a13e67529c62@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/rubygem-cookiejar
Branch : rawhide
Commit : a13e67529c62a6f019da8f46fe3f4d995144b2f3
Author : Mamoru TASAKA <mtasaka@fedoraproject.org>
Date   : 2026-09-21T16:15:59+09:00
Stats  : +31/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/rubygem-cookiejar/c/a13e67529c62a6f019da8f46fe3f4d995144b2f3?branch=rawhide

Log:
Skip some tests which depends on options removed on json 3

---
diff --git a/cookiejar-0.3.3-skip-test-with-json3.patch b/cookiejar-0.3.3-skip-test-with-json3.patch
new file mode 100644
index 0000000..21df4dc
--- /dev/null
+++ b/cookiejar-0.3.3-skip-test-with-json3.patch
@@ -0,0 +1,22 @@
+diff -urp '--exclude=*~' cookiejar-0.3.3.orig/spec/cookie_spec.rb cookiejar-0.3.3/spec/cookie_spec.rb
+--- cookiejar-0.3.3.orig/spec/cookie_spec.rb	2026-09-21 15:18:42.280319067 +0900
++++ cookiejar-0.3.3/spec/cookie_spec.rb	2026-09-21 16:06:18.443894333 +0900
+@@ -162,6 +162,7 @@ describe Cookie do
+         CookieValidation.validate_cookie 'https://localhost/', c
+       end
+       it 'should automatically deserialize to a cookie' do
++        skip "Creating class with create_additions option no longer supported on json 3" if JSON::VERSION.to_i >= 3
+         json = '{"json_class":"CookieJar::Cookie","name":"foo","value":"bar","domain":"localhost.local","path":"\\/","created_at":"2009-09-11 12:51:03 -0600","expiry":"2009-09-11 19:10:00 -0600","secure":true}'
+         c = JSON.parse json, create_additions: true
+         expect(c).to be_a Cookie
+diff -urp '--exclude=*~' cookiejar-0.3.3.orig/spec/jar_spec.rb cookiejar-0.3.3/spec/jar_spec.rb
+--- cookiejar-0.3.3.orig/spec/jar_spec.rb	2026-09-21 15:18:42.489463835 +0900
++++ cookiejar-0.3.3/spec/jar_spec.rb	2026-09-21 16:06:33.687601604 +0900
+@@ -219,6 +219,7 @@ describe Jar do
+       end
+ 
+       it 'should automatically deserialize to a jar' do
++        skip "Creating class with create_additions option no longer supported on json 3" if JSON::VERSION.to_i >= 3
+         json = '{"json_class":"CookieJar::Jar","cookies":[{"name":"foo","value":"bar","domain":"localhost.local","path":"\\/","created_at":"2009-09-11 12:51:03 -0600","expiry":"2028-11-01 12:00:00 GMT","secure":true}]}'
+         jar = JSON.parse json, create_additions: true
+         expect(jar.get_cookies('https://localhost/').size).to eql(1)

diff --git a/rubygem-cookiejar.spec b/rubygem-cookiejar.spec
index e6279b5..8a947da 100644
--- a/rubygem-cookiejar.spec
+++ b/rubygem-cookiejar.spec
@@ -2,7 +2,7 @@
 
 Name: rubygem-%{gem_name}
 Version: 0.3.3
-Release: 21%{?dist}
+Release: 22%{?dist}
 Summary: Parsing and returning cookies in Ruby
 # Automatically converted from old format: BSD - review is highly recommended.
 License: LicenseRef-Callaway-BSD	
@@ -16,6 +16,10 @@ Patch1: cookiejar2-pr2-fix-regexp-3rd-arg.patch
 # Ref: https://github.com/ruby/uri/issues/125
 # Use URI::RFC2396_Parser explicitly for ruby34 (uri 1.0.1)
 Patch2: cookiejar-uri-1_0-use-rfc2396_regexp-explicitly.patch
+# Skip some test with json 3: creating class with create_additions option is removed
+# with json 3
+# ref: https://github.com/ruby/json/blob/v3.0.0/CHANGES.md?plain=1#L12
+Patch3: cookiejar-0.3.3-skip-test-with-json3.patch
 BuildRequires: rubygem(rspec)
 BuildRequires: ruby(release)
 BuildRequires: rubygems-devel 
@@ -42,6 +46,7 @@ Documentation for %{name}
 %patch -P0 -p1
 %patch -P1 -p1
 %patch -P2 -p1
+%patch -P3 -p1
 
 %build
 gem build ../%{gem_name}-%{version}.gemspec
@@ -77,6 +82,9 @@ cp -a .%{gem_dir}/* \
 %{gem_instdir}/Gemfile
 
 %changelog
+* Mon Sep 21 2026 Mamoru TASAKA <mtasaka@fedoraproject.org> - 0.3.3-22
+- Skip some tests which depends on options removed on json 3
+
 * Thu Jul 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 0.3.3-21
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_45_Mass_Rebuild
 

                 reply	other threads:[~2026-09-21  7:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178997498435.1.18237246929004298813.rpms-rubygem-cookiejar-a13e67529c62@fedoraproject.org \
    --to=mtasaka@fedoraproject.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox