public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Scott K Logan <logans@cottsay.net>
To: git-commits@fedoraproject.org
Subject: [rpms/pcl] f44: Extend Eigen3 patch to installed PCLConfig.cmake
Date: Mon, 21 Sep 2026 02:32:35 GMT [thread overview]
Message-ID: <178995795579.1.10317085480215799780.rpms-pcl-e82806c930f5@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/pcl
Branch : f44
Commit : e82806c930f5c8c9a780206a2c8f69df70450414
Author : Scott K Logan <logans@cottsay.net>
Date : 2026-09-20T22:32:21-04:00
Stats : +20/-1 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/pcl/c/e82806c930f5c8c9a780206a2c8f69df70450414?branch=f44
Log:
Extend Eigen3 patch to installed PCLConfig.cmake
The existing patch allows PCL to be built, but the same treatment is
needed in PCLConfig.cmake for downstream packages to build.
---
diff --git a/pcl-1.15.1-eigen5.patch b/pcl-1.15.1-eigen5.patch
index 81a2ad2..6cc7475 100644
--- a/pcl-1.15.1-eigen5.patch
+++ b/pcl-1.15.1-eigen5.patch
@@ -2,7 +2,8 @@ diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5e2e90d..f000000 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
-@@ -346,7 +346,12 @@ find_package(Threads REQUIRED)
+@@ -346,7 +346,12 @@ endif()
+ find_package(Threads REQUIRED)
# Eigen3 (required)
-find_package(Eigen3 3.3 REQUIRED NO_MODULE)
@@ -15,3 +16,21 @@ index 5e2e90d..f000000 100644
if(NOT EIGEN3_FOUND AND Eigen3_FOUND)
set(EIGEN3_FOUND ${Eigen3_FOUND})
endif()
+diff --git a/PCLConfig.cmake.in b/PCLConfig.cmake.in
+index 455e81e..bb23c9a 100644
+--- a/PCLConfig.cmake.in
++++ b/PCLConfig.cmake.in
+@@ -118,7 +118,12 @@ macro(find_eigen3)
+ if(PCL_ALL_IN_ONE_INSTALLER)
+ set(Eigen3_DIR "${PCL_ROOT}/3rdParty/Eigen3/share/eigen3/cmake/")
+ endif()
+- find_package(Eigen3 3.3 REQUIRED NO_MODULE)
++ find_package(Eigen3 REQUIRED NO_MODULE)
++ if(EIGEN3_VERSION_STRING AND EIGEN3_VERSION_STRING VERSION_LESS 3.3)
++ message(FATAL_ERROR "Eigen3 >= 3.3 is required, found ${EIGEN3_VERSION_STRING}")
++ endif()
++ # Fedora's Eigen 5 package advertises version 5.x even though it stays API-compatible.
++ # Ensure the legacy variable mirrors the newer one for downstream logic.
+ if(NOT EIGEN3_FOUND AND Eigen3_FOUND)
+ set(EIGEN3_FOUND ${Eigen3_FOUND})
+ endif()
reply other threads:[~2026-09-21 2:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178995795579.1.10317085480215799780.rpms-pcl-e82806c930f5@fedoraproject.org \
--to=logans@cottsay.net \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox