public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/libnetconf2] openssl4-f45: Address Fedora review issues
Date: Fri, 18 Sep 2026 06:35:08 GMT	[thread overview]
Message-ID: <178971330810.1.15449871393725263857.rpms-libnetconf2-c6f29fb04a87@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/libnetconf2
            Branch : openssl4-f45
            Commit : c6f29fb04a87180f4b05a62dc09684236b383654
            Author : Jakub Ružička <jakub.ruzicka@nic.cz>
            Date   : 2022-01-19T16:37:45+01:00
            Stats  : +9/-13 in 3 file(s)
            URL    : https://src.fedoraproject.org/rpms/libnetconf2/c/c6f29fb04a87180f4b05a62dc09684236b383654?branch=openssl4-f45

            Log:
            Address Fedora review issues

https://bugzilla.redhat.com/show_bug.cgi?id=2023307

---
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..1073b69
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+/libnetconf2-*.tar.gz

diff --git a/libnetconf2.spec b/libnetconf2.spec
index d793e83..98a723f 100644
--- a/libnetconf2.spec
+++ b/libnetconf2.spec
@@ -3,11 +3,10 @@ Version: 2.0.24
 Release: 1%{?dist}
 Summary: NETCONF protocol library
 Url: https://github.com/CESNET/libnetconf2
-Source: %{url}/archive/v%{version}.tar.gz
+Source: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
 License: BSD
 
 BuildRequires:  cmake
-BuildRequires:  make
 BuildRequires:  gcc
 BuildRequires:  libssh-devel
 BuildRequires:  openssl-devel
@@ -17,6 +16,7 @@ BuildRequires:  pkgconfig(libyang) >= 2
 Summary:    Headers of libnetconf2 library
 Conflicts:  libnetconf-devel
 Requires:   %{name}%{?_isa} = %{version}-%{release}
+Requires:   pkgconfig
 
 %description devel
 Headers of libnetconf library.
@@ -28,28 +28,22 @@ servers. NETCONF is the NETwork CONFiguration protocol introduced by IETF.
 
 %prep
 %autosetup -p1
-mkdir build
 
 %build
-cd build
-cmake \
-    -DCMAKE_INSTALL_PREFIX:PATH=%{_prefix} \
-    -DCMAKE_BUILD_TYPE:String="Release" \
-    -DCMAKE_C_FLAGS="${RPM_OPT_FLAGS}" \
-    -DCMAKE_CXX_FLAGS="${RPM_OPT_FLAGS}" \
-    ..
-make
+%cmake
+%cmake_build
 
 %install
-cd build
-make DESTDIR=%{buildroot} install
+%cmake_install
 
 
 %files
 %license LICENSE
+%doc README.md FAQ.md
 %{_libdir}/libnetconf2.so.2*
 
 %files devel
+%doc CODINGSTYLE.md
 %{_libdir}/libnetconf2.so
 %{_libdir}/pkgconfig/libnetconf2.pc
 %{_includedir}/*.h

diff --git a/sources b/sources
new file mode 100644
index 0000000..12c2215
--- /dev/null
+++ b/sources
@@ -0,0 +1 @@
+SHA512 (libnetconf2-2.0.24.tar.gz) = 05cba691bc47e49abf747a36a6dcc978a4163fd155a90609315585201e4e4d20c9a30b683180f5cf03aac5b6a37933917e61a895067dd172b8de2142ec542dfc

                 reply	other threads:[~2026-09-18  6:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178971330810.1.15449871393725263857.rpms-libnetconf2-c6f29fb04a87@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox