public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/perl-SDL] f43: Adapt tests to SDL-3.2.24
Date: Thu, 17 Sep 2026 11:59:44 GMT	[thread overview]
Message-ID: <178964638437.1.11518660201337322735.rpms-perl-SDL-2b8431735ba6@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/perl-SDL
Branch : f43
Commit : 2b8431735ba62bfa3525c925db9b9917b2b38e4a
Author : Petr Písař <ppisar@redhat.com>
Date   : 2025-10-07T14:32:46+02:00
Stats  : +63/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/perl-SDL/c/2b8431735ba62bfa3525c925db9b9917b2b38e4a?branch=f43

Log:
Adapt tests to SDL-3.2.24

---
diff --git a/SDL-2.548-Adapt-to-SDL-3.2.24.patch b/SDL-2.548-Adapt-to-SDL-3.2.24.patch
new file mode 100644
index 0000000..2d5a3df
--- /dev/null
+++ b/SDL-2.548-Adapt-to-SDL-3.2.24.patch
@@ -0,0 +1,56 @@
+From 8cd2c619916c09b327c3230b975d1eace2924d58 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
+Date: Tue, 7 Oct 2025 14:16:23 +0200
+Subject: [PATCH] Adapt to SDL 3.2.24
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+After upgrading SDL from 3.2.22 to 3.2.24 t/core.t started to fail
+like this:
+
+    #   Failed test '[get_error] got error '
+    #   at t/core.t line 69.
+    #          got: ''
+    #     expected: anything else
+    # Looks like you failed 1 test of 28.
+    t/core.t ........................ Dubious, test returned 1 (wstat 256, 0x100)
+    Failed 1/28 subtests
+	    (3 TODO tests unexpectedly succeeded)
+
+The failure is triggered by SDL 5594d03da086ab255b1d7ace1496f3a0c109a83d commit
+("Leave letterbox borders set to the frame clear color").
+
+SDL_SetVideoMode(640, 480, 232, SDL_ANYFORMAT) kept succeeding, but
+SDL_GetError() stopped returning "rect has a negative size" error.
+
+Because the new behavior is more consistent and because the Perl test
+checks for SDL::get_error() instead of SDL::Video::set_video_mode()
+return value, I conlude that the Perl test wants to test
+SDL::get_error() and uses SDL::Video::set_video_mode() only as a way
+to produce an error.
+
+Thus this patch uses a different SDL::Video::set_video_mode()
+arguments to obtain an error ("Invalid width or height").
+
+Signed-off-by: Petr Písař <ppisar@redhat.com>
+---
+ t/core.t | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/t/core.t b/t/core.t
+index 1ccac868..8b35b9bc 100644
+--- a/t/core.t
++++ b/t/core.t
+@@ -62,7 +62,7 @@ is( SDL_INIT_EVENTTHREAD(), 16777216,
+ 	'SDL_INIT_EVENTTHREAD() should also be available'
+ );
+ 
+-my $display = SDL::Video::set_video_mode( 640, 480, 232, SDL_ANYFORMAT );
++my $display = SDL::Video::set_video_mode( -1, 480, 232, SDL_ANYFORMAT );
+ 
+ isnt( SDL::get_error(), '', '[get_error] got error ' . SDL::get_error() );
+ TODO:
+-- 
+2.51.0
+

diff --git a/perl-SDL.spec b/perl-SDL.spec
index d868720..e3ddb17 100644
--- a/perl-SDL.spec
+++ b/perl-SDL.spec
@@ -1,6 +1,6 @@
 Name:           perl-SDL
 Version:        2.548
-Release:        30%{?dist}
+Release:        31%{?dist}
 Summary:        Simple DirectMedia Layer for Perl
 # COPYING:                      GPL-2.0 text
 # lib/pods/SDL.pod:             GPL-1.0-or-later OR Artistic-1.0-Perl
@@ -61,6 +61,9 @@ Patch4:         SDL-2.548-Fix-building-in-ISO-C23.patch
 # Adapt t/core_surface.t test to SDL3, incompatible with SDL2, bug #2341036,
 # proposed to upstream, <https://github.com/PerlGameDev/SDL/pull/310>
 Patch5:         SDL-2.548-core_surface.t-test-data-icon.bmp-is-really-4-bits-p.patch
+# Adapt t/core.t test to SDL-3.2.24, bug #2401791, proposed upstream,
+# <https://github.com/PerlGameDev/SDL/pull/311>
+Patch6:         SDL-2.548-Adapt-to-SDL-3.2.24.patch
 BuildRequires:  coreutils
 BuildRequires:  findutils
 BuildRequires:  libGLU-devel
@@ -189,6 +192,9 @@ find %{buildroot} -type f -name '*.bs' -a -size 0 -delete
 %{_mandir}/man3/Module::Build::SDL.*
 
 %changelog
+* Tue Oct 07 2025 Petr Pisar <ppisar@redhat.com> - 2.548-31
+- Adapt tests to SDL-3.2.24 (bug #2401791)
+
 * Fri Jul 25 2025 Fedora Release Engineering <releng@fedoraproject.org> - 2.548-30
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild
 

                 reply	other threads:[~2026-09-17 11:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178964638437.1.11518660201337322735.rpms-perl-SDL-2b8431735ba6@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox