public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Than Ngo <than@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/chromium] rawhide: Fix FTBFS with old pipewire on fedora < 44 and epel
Date: Wed, 16 Sep 2026 14:10:05 GMT	[thread overview]
Message-ID: <178956780587.1.7884663294811201507.rpms-chromium-cfaddc492b6c@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/chromium
Branch : rawhide
Commit : cfaddc492b6cd9784707f181af16d960e1cfa29d
Author : Than Ngo <than@redhat.com>
Date   : 2026-09-16T16:09:44+02:00
Stats  : +48/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/chromium/c/cfaddc492b6cd9784707f181af16d960e1cfa29d?branch=rawhide

Log:
Fix FTBFS with old pipewire on fedora < 44 and epel

---
diff --git a/chromium-153-ftbfs-pipewire-api.patch b/chromium-153-ftbfs-pipewire-api.patch
new file mode 100644
index 0000000..385e053
--- /dev/null
+++ b/chromium-153-ftbfs-pipewire-api.patch
@@ -0,0 +1,44 @@
+Fix FTBFS with old pipewire
+
+ error: use of undeclared identifier 'spa_pod_type_size'
+
+diff -up chromium-153.0.8010.36/third_party/webrtc/modules/video_capture/linux/pipewire_session.cc.me chromium-153.0.8010.36/third_party/webrtc/modules/video_capture/linux/pipewire_session.cc
+--- chromium-153.0.8010.36/third_party/webrtc/modules/video_capture/linux/pipewire_session.cc.me	2026-09-16 08:52:36.959680086 +0200
++++ chromium-153.0.8010.36/third_party/webrtc/modules/video_capture/linux/pipewire_session.cc	2026-09-16 14:57:45.237435143 +0200
+@@ -46,9 +46,36 @@
+ namespace webrtc {
+ namespace videocapturemodule {
+ 
++#if defined(PIPEWIRE_VERSION_MAJOR) && \
++    (PIPEWIRE_VERSION_MAJOR < 1 || \
++     (PIPEWIRE_VERSION_MAJOR == 1 && PIPEWIRE_VERSION_MINOR < 5))
++// spa_pod_type_size() is not available in the SPA headers shipped with
++// older PipeWire versions. These are the only POD types for which this
++// file performs size validation.
++static uint32_t SpaPodTypeSize(uint32_t type) {
++  switch (type) {
++    case SPA_TYPE_Fraction:
++      return sizeof(struct spa_fraction);
++    case SPA_TYPE_Rectangle:
++      return sizeof(struct spa_rectangle);
++    case SPA_TYPE_Id:
++      return sizeof(uint32_t);
++    default:
++      RTC_DCHECK_NOTREACHED();
++      return 0;
++  }
++}
++#endif
++
+ // Checks that the pod matches the expected type and is large enough to hold it.
+ static bool SpaValueIsType(const spa_pod* val, uint32_t type) {
++#if defined(PIPEWIRE_VERSION_MAJOR) && \
++    (PIPEWIRE_VERSION_MAJOR < 1 || \
++     (PIPEWIRE_VERSION_MAJOR == 1 && PIPEWIRE_VERSION_MINOR < 5))
++  return val->type == type && val->size >= SpaPodTypeSize(type);
++#else
+   return val->type == type && val->size >= spa_pod_type_size(type);
++#endif
+ }
+ 
+ VideoType PipeWireRawFormatToVideoType(uint32_t id) {

diff --git a/chromium.spec b/chromium.spec
index 6fef9b3..2f993c2 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -300,6 +300,9 @@ Patch23: chromium-152-build-error-libpng_for_testonly.patch
 # patch from Melvin - melvin@pixilab.se
 Patch24: glibc-2.42-baud-rate-fix.patch
 
+# fix FTBFS with old pipewire on fedora < 44 and epel
+Patch25: chromium-153-ftbfs-pipewire-api.patch
+
 # disable enterprise_companion_integration_tests due to Unresolved dependencies
 Patch31: chromium-145-disable-enterprise_companion_integration_tests.patch
 
@@ -1077,6 +1080,7 @@ Qt6 UI for chromium.
 %if 0%{?fedora} || 0%{?rhel} && 0%{?rhel} > 10
 %patch -P24 -p1 -b .glibc-2.42-baud-rate-fix
 %endif
+%patch -P25 -p1 -b .ftbfs-pipewire-api
 %patch -P31 -p1 -b .disable-enterprise_companion_integration_tests
 
 %if ! %{bundlebrotli}

                 reply	other threads:[~2026-09-16 14:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178956780587.1.7884663294811201507.rpms-chromium-cfaddc492b6c@fedoraproject.org \
    --to=than@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox