public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Cristian Le <git@lecris.dev>
To: git-commits@fedoraproject.org
Subject: [rpms/pcs] f44: Drop git requirement
Date: Wed, 16 Sep 2026 12:21:28 GMT [thread overview]
Message-ID: <178956128877.1.12488000545554564606.rpms-pcs-2af1982dd151@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/pcs
Branch : f44
Commit : 2af1982dd151e114be2c13e3bcc6cb90f3acb0ab
Author : Cristian Le <git@lecris.dev>
Date : 2026-09-11T20:04:00+02:00
Stats : +1/-3 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/pcs/c/2af1982dd151e114be2c13e3bcc6cb90f3acb0ab?branch=f44
Log:
Drop git requirement
The git was only used for patches, but autopatch -p1 can handle git
patches just fine by itself.
Notes from mpospisi@redhat.com:
The original issue that this solves was an issue with TMT that couldn't
finish testing because git started doing some garbage collection in the
background. TMT uses rsync to move files in the background and it didn't
like that git was chnaging files around. The issue was reported to TMT:
https://github.com/teemtee/tmt/issues/4893
I didn't initially approve of this change because this relies on the
patch utility discarding garbage to use the git patches we produce from
the pcs_build repo. It also counts on the fact that git produces patches
that are compatible with the patch utility.
---
diff --git a/pcs.spec b/pcs.spec
index 2b55050..3ae6c1e 100644
--- a/pcs.spec
+++ b/pcs.spec
@@ -93,8 +93,6 @@ Obsoletes: pcs < 0.12.0
Recommends: %{pkg_pcs_web_ui} == %{version}-%{release}
-# git for patches
-BuildRequires: git-core
# for building pcs tarballs
BuildRequires: autoconf
BuildRequires: automake
@@ -339,7 +337,7 @@ update_times_patch(){
# update_times_patch %%{PATCH201}
# patch pcs sources
-%autosetup -S git -n %{pcs_source_name} -N
+%autosetup -n %{pcs_source_name} -N
%autopatch -p1 -M 200
# update_times_patch %%{PATCH1}
update_times_patch %{PATCH1}
reply other threads:[~2026-09-16 12:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178956128877.1.12488000545554564606.rpms-pcs-2af1982dd151@fedoraproject.org \
--to=git@lecris.dev \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox