public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Ondrej Holy <oholy@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/vlc] rawhide: Disable freerdp support
Date: Tue, 15 Sep 2026 15:38:23 GMT [thread overview]
Message-ID: <178948670325.1.13789283770699779842.rpms-vlc-525f2ec05114@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/vlc
Branch : rawhide
Commit : 525f2ec05114340a5558a91cda3f431e0efe5b45
Author : Ondrej Holy <oholy@redhat.com>
Date : 2026-09-15T14:30:36+00:00
Stats : +14/-1 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/vlc/c/525f2ec05114340a5558a91cda3f431e0efe5b45?branch=rawhide
Log:
Disable freerdp support
Currently, vlc builds with `pkgconfig(freerdp2)`. freerdp2 is being removed
from Fedora and freerdp3 is not yet supported upstream. Let's conditionalize
the `plugin-rdp` subpackage with `%bcond freerdp 0` and obsolete it so it
can be re-enabled once upstream adds freerdp3 support.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
diff --git a/vlc.spec b/vlc.spec
index adbfada..69c34fd 100644
--- a/vlc.spec
+++ b/vlc.spec
@@ -15,6 +15,8 @@
%bcond postproc %[!(0%{?fedora} >= 44 || 0%{?rhel} >= 11)]
# disabled due to various issues
%bcond projectm 0
+# freerdp3 not yet supported upstream
+%bcond freerdp 0
# some dependencies are not yet in EPEL 10
%bcond daala 1
@@ -134,7 +136,9 @@ BuildRequires: pkgconfig(flac)
#BuildRequires: pkgconfig(fluidlite)
BuildRequires: pkgconfig(fluidsynth) >= 1.1.2
BuildRequires: pkgconfig(fontconfig) >= 2.11
+%if %{with freerdp}
BuildRequires: pkgconfig(freerdp2)
+%endif
BuildRequires: pkgconfig(freetype2)
BuildRequires: pkgconfig(fribidi)
BuildRequires: pkgconfig(gl)
@@ -361,7 +365,9 @@ Requires: (%{name}-plugin-notify%{?_isa} = %{epoch}:%{version}-%{release} if gtk
Requires: %{name}-plugin-opencv%{?_isa} = %{epoch}:%{version}-%{release}
%endif
Requires: (%{name}-plugin-pulseaudio%{?_isa} = %{epoch}:%{version}-%{release} if (pipewire-pulseaudio or pulseaudio))
+%if %{with freerdp}
Requires: %{name}-plugin-rdp%{?_isa} = %{epoch}:%{version}-%{release}
+%endif
Requires: %{name}-plugin-samba%{?_isa} = %{epoch}:%{version}-%{release}
Requires: %{name}-plugin-svg%{?_isa} = %{epoch}:%{version}-%{release}
Requires: %{name}-plugin-visualization%{?_isa} = %{epoch}:%{version}-%{release}
@@ -394,6 +400,9 @@ Obsoletes: %{name}-plugin-ieee1394 < %{epoch}:%{version}-%{release}
%if %{without opencv}
Obsoletes: %{name}-plugin-opencv < %{epoch}:%{version}-%{release}
%endif
+%if %{without freerdp}
+Obsoletes: %{name}-plugin-rdp < %{epoch}:%{version}-%{release}
+%endif
%description plugins-base
VLC media player core components
@@ -518,6 +527,7 @@ Requires: %{name}-plugins-base%{?_isa} = %{epoch}:%{version}-%{release}
%description plugin-pulseaudio
PulseAudio plugins for VLC media player
+%if %{with freerdp}
# requires freerdp2, for RDP remote desktop support
%package plugin-rdp
Summary: VLC media player RDP plugin
@@ -525,6 +535,7 @@ Requires: %{name}-libs%{?_isa} = %{epoch}:%{version}-%{release}
Requires: %{name}-plugins-base%{?_isa} = %{epoch}:%{version}-%{release}
%description plugin-rdp
RDP access plugin for VLC media player
+%endif
# requires libsmbclient, for SMB protocol support
%package plugin-samba
@@ -630,7 +641,7 @@ export LIVE555_PREFIX=%{_prefix}
--enable-libcddb \
--enable-screen \
--enable-vnc \
- --enable-freerdp \
+ --enable-freerdp%{!?with_freerdp:=no} \
--enable-realrtsp \
--enable-asdcp%{!?with_asdcp:=no} \
\
@@ -1240,8 +1251,10 @@ make check
%{vlc_plugindir}/audio_output/libpulse_plugin.so
%{vlc_plugindir}/services_discovery/libpulselist_plugin.so
+%if %{with freerdp}
%files plugin-rdp
%{vlc_plugindir}/access/librdp_plugin.so
+%endif
%files plugin-samba
%{vlc_plugindir}/access/libsmb_plugin.so
reply other threads:[~2026-09-15 15:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178948670325.1.13789283770699779842.rpms-vlc-525f2ec05114@fedoraproject.org \
--to=oholy@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox