public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Steve Cossette <farchord@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/lutris] rawhide: Fix for running on newer gnome versions
Date: Fri, 11 Sep 2026 19:47:22 GMT	[thread overview]
Message-ID: <178915604224.1.18132569946813201661.rpms-lutris-c6623c1cf1aa@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/lutris
Branch : rawhide
Commit : c6623c1cf1aad4e77342ba3b4763d527e3b7c163
Author : Steve Cossette <farchord@gmail.com>
Date   : 2026-09-11T15:46:56-04:00
Stats  : +78/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/lutris/c/c6623c1cf1aad4e77342ba3b4763d527e3b7c163?branch=rawhide

Log:
Fix for running on newer gnome versions

---
diff --git a/6833.patch b/6833.patch
new file mode 100644
index 0000000..ea399e8
--- /dev/null
+++ b/6833.patch
@@ -0,0 +1,74 @@
+From fd91646fbae9b0f7ce90fb5d7dda34e8f13856fe Mon Sep 17 00:00:00 2001
+From: Tim Coninx <tim.coninx@gmail.com>
+Date: Wed, 12 Aug 2026 16:05:08 +0200
+Subject: [PATCH 1/3] Check for deprecated attributes in GnomeDesktop which
+ have been removed in newer versions. This prevents AttributeError when trying
+ to access them.
+
+---
+ lutris/util/display.py | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/lutris/util/display.py b/lutris/util/display.py
+index d8f96861f0..6b0e243d95 100644
+--- a/lutris/util/display.py
++++ b/lutris/util/display.py
+@@ -14,9 +14,11 @@
+ try:
+     gi.require_version("GnomeDesktop", "3.0")
+     from gi.repository import GnomeDesktop  # type: ignore
++    # check for AttributeError on newer systems on which the deprecated attributes have been removed
++    GnomeDesktop.RRScreen  # type: ignore
+ 
+     LIB_GNOME_DESKTOP_AVAILABLE = True
+-except ValueError:
++except (ValueError, AttributeError):
+     LIB_GNOME_DESKTOP_AVAILABLE = False
+     GnomeDesktop = None
+ 
+
+From 68197a0686526df1c117d4e2506d5fd8af4cb2ae Mon Sep 17 00:00:00 2001
+From: Tim Coninx <tim.coninx@gmail.com>
+Date: Wed, 12 Aug 2026 16:15:02 +0200
+Subject: [PATCH 2/3] Comment formatting
+
+---
+ lutris/util/display.py | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/lutris/util/display.py b/lutris/util/display.py
+index 6b0e243d95..f468e89a8c 100644
+--- a/lutris/util/display.py
++++ b/lutris/util/display.py
+@@ -14,7 +14,8 @@
+ try:
+     gi.require_version("GnomeDesktop", "3.0")
+     from gi.repository import GnomeDesktop  # type: ignore
+-    # check for AttributeError on newer systems on which the deprecated attributes have been removed
++    # check for AttributeError on newer systems on which the
++    # deprecated attributes have been removed
+     GnomeDesktop.RRScreen  # type: ignore
+ 
+     LIB_GNOME_DESKTOP_AVAILABLE = True
+
+From 27ba1c90242597e72380fdc505249581fb8ddb44 Mon Sep 17 00:00:00 2001
+From: Tim Coninx <tim.coninx@gmail.com>
+Date: Wed, 12 Aug 2026 16:24:06 +0200
+Subject: [PATCH 3/3] Ruff formatting
+
+---
+ lutris/util/display.py | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/lutris/util/display.py b/lutris/util/display.py
+index f468e89a8c..0a47b3cdae 100644
+--- a/lutris/util/display.py
++++ b/lutris/util/display.py
+@@ -14,6 +14,7 @@
+ try:
+     gi.require_version("GnomeDesktop", "3.0")
+     from gi.repository import GnomeDesktop  # type: ignore
++
+     # check for AttributeError on newer systems on which the
+     # deprecated attributes have been removed
+     GnomeDesktop.RRScreen  # type: ignore

diff --git a/lutris.spec b/lutris.spec
index 575f55b..0b86749 100644
--- a/lutris.spec
+++ b/lutris.spec
@@ -9,6 +9,10 @@ License:        GPL-3.0-only
 URL:            http://%{name}.net
 Source0:        https://github.com/%{name}/%{name}/archive/refs/tags/v%{version}.tar.gz
 
+# Check for deprecated attributes in GnomeDesktop
+# https://github.com/lutris/lutris/pull/6833
+Patch0:         6833.patch
+
 BuildRequires:  desktop-file-utils
 BuildRequires:  python3-devel
 Requires:       cabextract

                 reply	other threads:[~2026-09-11 19:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178915604224.1.18132569946813201661.rpms-lutris-c6623c1cf1aa@fedoraproject.org \
    --to=farchord@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox