public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Owen W. Taylor <otaylor@fishsoup.net>
To: git-commits@fedoraproject.org
Subject: [flatpaks/flatpak-runtime] f45: Distinguish "root" packages
Date: Fri, 11 Sep 2026 14:40:09 GMT [thread overview]
Message-ID: <178913760962.1.12183061058520249693.flatpaks-flatpak-runtime-c89337c92826@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : flatpaks/flatpak-runtime
Branch : f45
Commit : c89337c9282696a799e0ced195b16488ed09df2b
Author : Owen W. Taylor <otaylor@fishsoup.net>
Date : 2018-01-31T11:21:01+01:00
Stats : +54/-10 in 3 file(s)
URL : https://src.fedoraproject.org/flatpaks/flatpak-runtime/c/c89337c9282696a799e0ced195b16488ed09df2b?branch=f45
Log:
Distinguish "root" packages
Show in darker gray packages that are pulled in because files exist
in the upstream runtime but aren't required by anything else. These
are the packages that are candidates for exclusion. (Excluding these
may, of course, create more root packages.)
---
diff --git a/generate-report.py b/generate-report.py
index d00dd90..44496b2 100755
--- a/generate-report.py
+++ b/generate-report.py
@@ -108,6 +108,45 @@ class Package(object):
def gnome_sdk_why(self):
return self.why('gnome_sdk')
+ def inclusion(self, which):
+ level = getattr(self, which)
+ if level == 0:
+ return 'absent'
+ elif level == 1:
+ return 'dep'
+ else:
+ required_by = getattr(self, which + '_required_by', False)
+ if required_by is False:
+ return 'present'
+ elif required_by is not None and len(required_by) > 0:
+ return 'files'
+ else:
+ return 'root'
+
+ @property
+ def freedesktop_platform_inclusion(self):
+ return self.inclusion('freedesktop_platform')
+
+ @property
+ def freedesktop_sdk_inclusion(self):
+ return self.inclusion('freedesktop_sdk')
+
+ @property
+ def gnome_platform_inclusion(self):
+ return self.inclusion('gnome_platform')
+
+ @property
+ def gnome_sdk_inclusion(self):
+ return self.inclusion('gnome_sdk')
+
+ @property
+ def live_inclusion(self):
+ return self.inclusion('live')
+
+ @property
+ def rf26_inclusion(self):
+ return self.inclusion('rf26')
+
class Letter(object):
def __init__(self, letter):
self.letter = letter
diff --git a/report-template.html b/report-template.html
index 5b97bbf..8234614 100644
--- a/report-template.html
+++ b/report-template.html
@@ -43,12 +43,12 @@
{% for package in letter.packages %}
<tr class="package {{ package.klass }}">
<td>{{ package.name }}</td>
- <td class="{{('absent','dep','present')[package.freedesktop_platform]}}" title="{{ package.freedesktop_platform_why }}"></td>
- <td class="{{('absent','dep','present')[package.gnome_platform]}}" title="{{ package.gnome_platform_why }}"></td>
- <td class="{{('absent','dep','present')[package.freedesktop_sdk]}}" title="{{ package.freedesktop_sdk_why }}"></td>
- <td class="{{('absent','dep','present')[package.gnome_sdk]}}" title="{{ package.gnome_sdk_why }}"></td>
- <td class="{{('absent','dep','present')[package.live]}}"></td>
- <td class="{{('absent','dep','present')[package.rf26]}}"></td>
+ <td class="{{package.freedesktop_platform_inclusion}}" title="{{ package.freedesktop_platform_why }}"></td>
+ <td class="{{package.gnome_platform_inclusion}}" title="{{ package.gnome_platform_why }}"></td>
+ <td class="{{package.freedesktop_sdk_inclusion}}" title="{{ package.freedesktop_sdk_why }}"></td>
+ <td class="{{package.gnome_sdk_inclusion}}" title="{{ package.gnome_sdk_why }}"></td>
+ <td class="{{package.live_inclusion}}"></td>
+ <td class="{{package.rf26_inclusion}}"></td>
<td>{{ package.modules}} </td>
<td>{{ package.note }}</td>
</tr>
diff --git a/report.css b/report.css
index 0b27390..cbc824d 100644
--- a/report.css
+++ b/report.css
@@ -61,18 +61,23 @@ tr {
border-left: 1px solid #aa8888;
border-right: 1px solid #aa8888;
}
-td.present {
+td.root {
+ background: #888888;
+ border: 1px solid #666666;
+ padding: 0px;
+}
+td.present, td.files {
background: #aaaaaa;
- border: 1px solid #888888;
+ border: 1px solid #666666;
padding: 0px;
}
td.dep {
background: #cccccc;
- border: 1px solid #888888;
+ border: 1px solid #666666;
padding: 0px;
}
td.absent {
- border: 1px solid #888888;
+ border: 1px solid #666666;
padding: 0px;
}
tr.not-on-live {
reply other threads:[~2026-09-11 14:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178913760962.1.12183061058520249693.flatpaks-flatpak-runtime-c89337c92826@fedoraproject.org \
--to=otaylor@fishsoup.net \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox