public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Milos Malik <mmalik@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: improve the gnome-remote-desktop test
Date: Fri, 11 Sep 2026 13:23:30 GMT	[thread overview]
Message-ID: <178913301055.1.15311668857107843150.tests-selinux-f3c03861940d@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : f3c03861940dd49c058fb3fbae68ab50d1b3e686
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2026-01-23T18:21:27+00:00
            Stats  : +13/-1 in 3 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/f3c03861940dd49c058fb3fbae68ab50d1b3e686?branch=pr775-checkpolicy-revdeps

            Log:
            improve the gnome-remote-desktop test

The gnome-remote-desktop service was not configured properly and
that's why the test failed for a long time. The issue should be
fixed now.

---
diff --git a/selinux-policy/gnome-remote-desktop-and-similar/Makefile b/selinux-policy/gnome-remote-desktop-and-similar/Makefile
index bc72237..c68a44f 100644
--- a/selinux-policy/gnome-remote-desktop-and-similar/Makefile
+++ b/selinux-policy/gnome-remote-desktop-and-similar/Makefile
@@ -55,7 +55,7 @@ $(METADATA): Makefile
 	@echo "TestTime:        10m" >> $(METADATA)
 	@echo "RunFor:          gnome-remote-desktop" >> $(METADATA)
 	@echo "RunFor:          selinux-policy" >> $(METADATA)
-	@echo "Requires:        audit libselinux libselinux-utils policycoreutils selinux-policy selinux-policy-targeted setools-console /usr/sbin/service gnome-remote-desktop gdm" >> $(METADATA)
+	@echo "Requires:        audit libselinux libselinux-utils policycoreutils selinux-policy selinux-policy-targeted setools-console /usr/sbin/service gnome-remote-desktop gdm freerdp" >> $(METADATA)
 	@echo "RhtsRequires:    library(selinux-policy/common)" >> $(METADATA)
 	@echo "Priority:        Normal" >> $(METADATA)
 	@echo "License:         GPLv2" >> $(METADATA)

diff --git a/selinux-policy/gnome-remote-desktop-and-similar/main.fmf b/selinux-policy/gnome-remote-desktop-and-similar/main.fmf
index 7f84971..33cd021 100644
--- a/selinux-policy/gnome-remote-desktop-and-similar/main.fmf
+++ b/selinux-policy/gnome-remote-desktop-and-similar/main.fmf
@@ -4,6 +4,7 @@ description: |+
 
 contact: Milos Malik <mmalik@redhat.com>
 component:
+  - gnome-remote-desktop
   - selinux-policy
 test: ./runtest.sh
 framework: beakerlib
@@ -20,6 +21,7 @@ recommend:
   - /usr/sbin/service
   - gnome-remote-desktop
   - gdm
+  - freerdp
 environment:
     AVC_ERROR: +no_avc_check
 duration: 10m

diff --git a/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh b/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh
index 9c72937..2349eb1 100755
--- a/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh
+++ b/selinux-policy/gnome-remote-desktop-and-similar/runtest.sh
@@ -73,6 +73,15 @@ rlJournalStart
 
     if [ -f /usr/lib/systemd/system/gnome-remote-desktop.service ] ; then
     rlPhaseStartTest "real scenario"
+        rlRun "rm -rf ~gnome-remote-desktop/.local/share/gnome-remote-desktop"
+        rlRun "sudo -u gnome-remote-desktop mkdir -p ~gnome-remote-desktop/.local/share/gnome-remote-desktop"
+        rlRun "sudo -u gnome-remote-desktop winpr-makecert -silent -rdp -path ~gnome-remote-desktop/.local/share/gnome-remote-desktop tls"
+        rlRun "grdctl --system rdp set-tls-key ~gnome-remote-desktop/.local/share/gnome-remote-desktop/tls.key"
+        rlRun "grdctl --system rdp set-tls-cert ~gnome-remote-desktop/.local/share/gnome-remote-desktop/tls.crt"
+        rlRun "grdctl --system rdp set-credentials nobody nothing"
+        rlRun "grdctl --system rdp enable"
+        rlRun "systemctl enable --now gdm"
+        sleep 2
         rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "start status" 1
         rlRun "grdctl --headless status"
         rlRun "grdctl --system status"
@@ -81,6 +90,7 @@ rlJournalStart
         rlRun "grdctl --system status"
         rlRun "restorecon -Rv /etc /run /var -e /var/ARTIFACTS" 0-255
         rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "restart status stop status" 1
+        rlRun "systemctl stop gdm"
     rlPhaseEnd
     fi
 

                 reply	other threads:[~2026-09-11 13:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913301055.1.15311668857107843150.tests-selinux-f3c03861940d@fedoraproject.org \
    --to=mmalik@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox