[tests/selinux] pr775-checkpolicy-revdeps: add new test which covers the valkey* services

[Milos Malik <mmalik@redhat.com>]

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 16ec518546238a8944df393c3fc03ebfb48adc7f
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2025-08-18T08:25:14+00:00
            Stats  : +215/-0 in 4 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/16ec518546238a8944df393c3fc03ebfb48adc7f?branch=pr775-checkpolicy-revdeps

            Log:
            add new test which covers the valkey* services

The valkey component is a replacement for the redis component. The
automated test covers basic functions of the valkey* services.

The TC covers RHEL-102631.

---
diff --git a/selinux-policy/valkey-and-similar/Makefile b/selinux-policy/valkey-and-similar/Makefile
new file mode 100644
index 0000000..2e576bf
--- /dev/null
+++ b/selinux-policy/valkey-and-similar/Makefile
@@ -0,0 +1,70 @@
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Makefile of /CoreOS/selinux-policy/Regression/valkey-and-similar
+#   Description: SELinux interferes with valkey and related programs
+#   Author: Milos Malik <mmalik@redhat.com>
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Copyright (c) 2025 Red Hat, Inc. All rights reserved.
+#
+#   This copyrighted material is made available to anyone wishing
+#   to use, modify, copy, or redistribute it subject to the terms
+#   and conditions of the GNU General Public License version 2.
+#
+#   This program is distributed in the hope that it will be
+#   useful, but WITHOUT ANY WARRANTY; without even the implied
+#   warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+#   PURPOSE. See the GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU General Public
+#   License along with this program; if not, write to the Free
+#   Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+#   Boston, MA 02110-1301, USA.
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+export TEST=/CoreOS/selinux-policy/Regression/valkey-and-similar
+export TESTVERSION=1.0
+
+BUILT_FILES=
+
+FILES=$(METADATA) runtest.sh Makefile PURPOSE
+
+.PHONY: all install download clean
+
+run: $(FILES) build
+	./runtest.sh
+
+build: $(BUILT_FILES)
+	chmod a+x runtest.sh
+	chcon -t bin_t runtest.sh
+
+clean:
+	rm -f *~ $(BUILT_FILES)
+
+include /usr/share/rhts/lib/rhts-make.include
+
+$(METADATA): Makefile
+	@echo "Owner:           Milos Malik <mmalik@redhat.com>" > $(METADATA)
+	@echo "Name:            $(TEST)" >> $(METADATA)
+	@echo "TestVersion:     $(TESTVERSION)" >> $(METADATA)
+	@echo "Path:            $(TEST_DIR)" >> $(METADATA)
+	@echo "Description:     SELinux interferes with valkey and related programs" >> $(METADATA)
+	@echo "Type:            Regression" >> $(METADATA)
+	@echo "TestTime:        10m" >> $(METADATA)
+	@echo "RunFor:          selinux-policy" >> $(METADATA)
+	@echo "RunFor:          valkey" >> $(METADATA)
+	@echo "Requires:        audit libselinux libselinux-utils policycoreutils selinux-policy selinux-policy-targeted setools-console valkey /usr/sbin/service" >> $(METADATA)
+	@echo "RhtsRequires:    library(selinux-policy/common)" >> $(METADATA)
+	@echo "Priority:        Normal" >> $(METADATA)
+	@echo "License:         GPLv2" >> $(METADATA)
+	@echo "Confidential:    no" >> $(METADATA)
+	@echo "Destructive:     no" >> $(METADATA)
+	@echo "Environment:     AVC_ERROR=+no_avc_check" >> $(METADATA)
+	@echo "Releases:        -RHEL4 -RHEL5 -RHEL6 -RHEL7 -RHEL8" >> $(METADATA)
+	@echo "Bug:             RHEL-102631" >> $(METADATA) # RHEL-10
+	@echo "Bug:             RHEL-108982" >> $(METADATA) # RHEL-9
+
+	rhts-lint $(METADATA)
+

diff --git a/selinux-policy/valkey-and-similar/PURPOSE b/selinux-policy/valkey-and-similar/PURPOSE
new file mode 100644
index 0000000..e131f98
--- /dev/null
+++ b/selinux-policy/valkey-and-similar/PURPOSE
@@ -0,0 +1,5 @@
+PURPOSE of /CoreOS/selinux-policy/Regression/valkey-and-similar
+Author: Milos Malik <mmalik@redhat.com>
+
+SELinux interferes with valkey-server, valkey-sentinel and related programs.
+

diff --git a/selinux-policy/valkey-and-similar/main.fmf b/selinux-policy/valkey-and-similar/main.fmf
new file mode 100644
index 0000000..4029ed9
--- /dev/null
+++ b/selinux-policy/valkey-and-similar/main.fmf
@@ -0,0 +1,37 @@
+summary: SELinux interferes with valkey and related programs
+description: |+
+    SELinux interferes with valkey-server, valkey-sentinel and related programs.
+
+contact: Milos Malik <mmalik@redhat.com>
+component:
+  - selinux-policy
+test: ./runtest.sh
+framework: beakerlib
+require:
+  - library(selinux-policy/common)
+recommend:
+  - audit
+  - libselinux
+  - libselinux-utils
+  - policycoreutils
+  - selinux-policy
+  - selinux-policy-targeted
+  - setools-console
+  - valkey
+  - /usr/sbin/service
+environment:
+    AVC_ERROR: +no_avc_check
+duration: 10m
+enabled: true
+tier: '3'
+link:
+  - verifies: https://issues.redhat.com/browse/RHEL-102631
+  - verifies: https://issues.redhat.com/browse/RHEL-108982
+tag:
+  - Tier3
+  - Tier3se
+  - NoRHIVOS
+adjust:
+  - enabled: false
+    when: distro == rhel-4, rhel-5, rhel-6, rhel-7, rhel-8
+    because: the package is not available there

diff --git a/selinux-policy/valkey-and-similar/runtest.sh b/selinux-policy/valkey-and-similar/runtest.sh
new file mode 100755
index 0000000..4a356ed
--- /dev/null
+++ b/selinux-policy/valkey-and-similar/runtest.sh
@@ -0,0 +1,103 @@
+#!/bin/bash
+# vim: dict=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   runtest.sh of /CoreOS/selinux-policy/Regression/valkey-and-similar
+#   Description: SELinux interferes with valkey and related programs
+#   Author: Milos Malik <mmalik@redhat.com>
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Copyright (c) 2025 Red Hat, Inc. All rights reserved.
+#
+#   This copyrighted material is made available to anyone wishing
+#   to use, modify, copy, or redistribute it subject to the terms
+#   and conditions of the GNU General Public License version 2.
+#
+#   This program is distributed in the hope that it will be
+#   useful, but WITHOUT ANY WARRANTY; without even the implied
+#   warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+#   PURPOSE. See the GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU General Public
+#   License along with this program; if not, write to the Free
+#   Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+#   Boston, MA 02110-1301, USA.
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+# Include Beaker environment
+. /usr/share/beakerlib/beakerlib.sh || exit 1
+
+PACKAGE="selinux-policy"
+FILE_CONTEXT="redis_exec_t"
+SERVICE_PACKAGE="valkey"
+SERVICE_NAME="valkey"
+PROCESS_NAME="valkey-server"
+PROCESS_CONTEXT="redis_t"
+
+rlJournalStart
+    rlPhaseStartSetup
+        rlRun "rlImport 'selinux-policy/common'"
+        rlSESatisfyRequires
+        rlAssertRpm ${PACKAGE}
+        rlAssertRpm ${PACKAGE}-targeted
+        if rpm -qa | grep -q valkey ; then
+            rlAssertRpm ${SERVICE_PACKAGE}
+            rlServiceStop valkey valkey-sentinel
+        fi
+
+        rlSESetEnforce
+        rlSEStatus
+        rlSESetTimestamp
+        sleep 2
+    rlPhaseEnd
+
+    rlPhaseStartTest "RHEL-102631"
+        rlSEMatchPathCon `which valkey-server` ${FILE_CONTEXT}
+        rlSEMatchPathCon `which valkey-sentinel` ${FILE_CONTEXT}
+        rlSEMatchPathCon "/etc/valkey" "redis_conf_t"
+        rlSEMatchPathCon "/etc/valkey/sentinel.conf" "redis_conf_t"
+        rlSEMatchPathCon "/etc/valkey/valkey.conf" "redis_conf_t"
+        rlSEMatchPathCon "/var/log/valkey" "redis_log_t"
+        rlSEMatchPathCon "/var/lib/valkey" "redis_var_lib_t"
+        rlSEMatchPathCon "/var/run/valkey" "redis_var_run_t"
+        rlSEMatchPathCon "/usr/lib/systemd/system/valkey-sentinel.service" "redis_unit_file_t"
+        rlSEMatchPathCon "/usr/lib/systemd/system/valkey.service" "redis_unit_file_t"
+    rlPhaseEnd
+
+    if [ -f /usr/lib/systemd/system/${SERVICE_NAME}.service ] ; then
+    rlPhaseStartTest "real scenario -- ${SERVICE_NAME} service"
+        if ! rlSEDefined ${PROCESS_CONTEXT} ; then
+            PROCESS_CONTEXT="unconfined_service_t"
+        fi
+        rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "start status" 1
+        rlWatchdog "valkey-cli --stat" 10
+        rlRun "restorecon -Rv /etc /var /run -e /var/ARTIFACTS" 0-255
+        rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "restart status stop status" 1
+    rlPhaseEnd
+    fi
+
+    SERVICE_NAME="valkey-sentinel"
+    PROCESS_NAME="valkey-sentinel"
+
+    if [ -f /usr/lib/systemd/system/${SERVICE_NAME}.service ] ; then
+    rlPhaseStartTest "real scenario -- ${SERVICE_NAME} service"
+        if ! rlSEDefined ${PROCESS_CONTEXT} ; then
+            PROCESS_CONTEXT="unconfined_service_t"
+        fi
+        rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "start status" 1
+        rlWatchdog "valkey-cli --stat -u valkey://default:PASSWORD@localhost:26379/0" 10
+        rlRun "restorecon -Rv /etc /var /run -e /var/ARTIFACTS" 0-255
+        rlSEService - ${SERVICE_NAME} ${PROCESS_NAME} ${PROCESS_CONTEXT} "restart status stop status" 1
+    rlPhaseEnd
+    fi
+
+    rlPhaseStartCleanup
+        sleep 2
+        rlSECheckAVC
+        rlServiceRestore valkey valkey-sentinel
+    rlPhaseEnd
+rlJournalPrintText
+rlJournalEnd
+