public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Zdenek Pytela <zpytela@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: Check for bin/sulogin, not for /sbin/sulogin
Date: Fri, 11 Sep 2026 13:22:21 GMT	[thread overview]
Message-ID: <178913294172.1.10141882150571397318.tests-selinux-5660ee6918fd@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 5660ee6918fde28909c7ad151eff1159841680ca
            Author : Zdenek Pytela <zpytela@redhat.com>
            Date   : 2025-02-06T12:08:09+01:00
            Stats  : +1/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/5660ee6918fde28909c7ad151eff1159841680ca?branch=pr775-checkpolicy-revdeps

            Log:
            Check for bin/sulogin, not for /sbin/sulogin

With Unify_bin_and_sbin [1] in progres, majority of commands have
already been moved from /usr/sbin to /usr/bin in Fedora 42 and newer,
therefore the strings check in /usr/lib/systemd/systemd-sulogin-shell
should rather use bin/sulogin.

This commit fixes the following test failure:
[   FAIL   ] :: Command 'strings /usr/lib/systemd/systemd-sulogin-shell | grep /sbin/sulogin' (Expected 0, got 1)

[1] https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin

---
diff --git a/selinux-policy/sulogin-and-similar/runtest.sh b/selinux-policy/sulogin-and-similar/runtest.sh
index 6fbb8d9..073d423 100755
--- a/selinux-policy/sulogin-and-similar/runtest.sh
+++ b/selinux-policy/sulogin-and-similar/runtest.sh
@@ -25,7 +25,7 @@ rlJournalStart
 
     rlPhaseStartTest "real scenario -- standalone service"
         rlRun "grep ExecStart= /usr/lib/systemd/system/rescue.service"
-        rlRun "strings /usr/lib/systemd/systemd-sulogin-shell | grep /sbin/sulogin"
+        rlRun "strings /usr/lib/systemd/systemd-sulogin-shell | grep bin/sulogin"
         rlRun "service rescue start"
         sleep 2
         rlRun "service rescue status"

                 reply	other threads:[~2026-09-11 13:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913294172.1.10141882150571397318.tests-selinux-5660ee6918fd@fedoraproject.org \
    --to=zpytela@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox