public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Petr Lautrbach <lautrbach@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: libsemanage: drop disconnect tests
Date: Fri, 11 Sep 2026 13:22:13 GMT [thread overview]
Message-ID: <178913293331.1.2868038922309300343.tests-selinux-b0f6b28c82ac@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : tests/selinux
Branch : pr775-checkpolicy-revdeps
Commit : b0f6b28c82ac0c204dba19b7e1e4cb9d4f461a69
Author : Petr Lautrbach <lautrbach@redhat.com>
Date : 2024-12-04T18:36:42+00:00
Stats : +0/-5 in 2 file(s)
URL : https://src.fedoraproject.org/tests/selinux/c/b0f6b28c82ac0c204dba19b7e1e4cb9d4f461a69?branch=pr775-checkpolicy-revdeps
Log:
libsemanage: drop disconnect tests
It tests wrong behavior which is fixed in the latest libsemanage and
in order not to break test runs on older systems lets drop it.
Fixes:
semanage_handle_create(): 0x4f782c0
semanage_disconnect(0x4f782c0): 0
semanage_connect(0x4f782c0): 0
semanage_handle_destroy(0x4f782c0)
[ FAIL ] :: Command './test_connect handle reversed' (Expected 134, got 0)
---
diff --git a/libsemanage/sanity-tests/tests/test_handle.c b/libsemanage/sanity-tests/tests/test_handle.c
index 810014d..a508043 100644
--- a/libsemanage/sanity-tests/tests/test_handle.c
+++ b/libsemanage/sanity-tests/tests/test_handle.c
@@ -102,12 +102,8 @@ void test_connect(void) {
void test_disconnect(void) {
setup_handle(SH_NULL);
- CU_ASSERT_SIGNAL(semanage_disconnect(sh), SIGABRT);
-
helper_handle_create();
- CU_ASSERT_SIGNAL(semanage_disconnect(sh), SIGABRT);
-
helper_connect();
CU_ASSERT(semanage_disconnect(sh) >= 0);
diff --git a/libsemanage/semanage-handle-functions/runtest.sh b/libsemanage/semanage-handle-functions/runtest.sh
index b3e26a3..e29a22b 100755
--- a/libsemanage/semanage-handle-functions/runtest.sh
+++ b/libsemanage/semanage-handle-functions/runtest.sh
@@ -85,7 +85,6 @@ rlJournalStart
rlRun "./test_connect init reversed" $ERR_ABORT
rlRun "./test_connect handle"
rlRun "./test_connect handle twice"
- rlRun "./test_connect handle reversed" $ERR_ABORT
# why does it work??
rlRun "./test_connect conn"
rlPhaseEnd
reply other threads:[~2026-09-11 13:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178913293331.1.2868038922309300343.tests-selinux-b0f6b28c82ac@fedoraproject.org \
--to=lautrbach@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox