public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Milos Malik <mmalik@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: test if sepolgen-ifgen complains about illegal character
Date: Fri, 11 Sep 2026 13:21:38 GMT	[thread overview]
Message-ID: <178913289891.1.7094793276627923418.tests-selinux-55c2934207b0@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 55c2934207b077ed907a65b424ac99fab988d56f
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2024-05-06T08:54:27+00:00
            Stats  : +12/-0 in 2 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/55c2934207b077ed907a65b424ac99fab988d56f?branch=pr775-checkpolicy-revdeps

            Log:
            test if sepolgen-ifgen complains about illegal character

Several bug reports pointed out that the installation, reinstallation
or upgrade of the selinux-policy-devel package produces the following
error message:

  Illegal character '"'

Further investigation revealed that there are unexpected/redundant
parentheses in the /usr/share/selinux/devel/include/contrib/virt.if
file, which also cause the following error messages when the
sepolgen-ifgen command is executed:

  Missing interface definition for virt_pid_filetrans
  Missing interface definition for virt_systemctl

The TC is able to reproduces the problem when executed on a not yet
fixed package. The TC passes when the problem is fixed.

The TC covers BZ#2254169, BZ#2254206, BZ#2277925.

---
diff --git a/selinux-policy/interface-definitions/main.fmf b/selinux-policy/interface-definitions/main.fmf
index e54b879..8befb8d 100644
--- a/selinux-policy/interface-definitions/main.fmf
+++ b/selinux-policy/interface-definitions/main.fmf
@@ -6,6 +6,7 @@ component:
 recommend:
   - /usr/bin/sepolgen-ifgen
   - selinux-policy
+  - selinux-policy-devel
   - selinux-policy-targeted
 test: ./runtest.sh
 framework: beakerlib
@@ -19,6 +20,10 @@ tag:
 link:
   - verifies: https://issues.redhat.com/browse/RHEL-2616
   - verifies: https://issues.redhat.com/browse/RHEL-16185
+  - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2254169
+  - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2254206
+  - verifies: https://bugzilla.redhat.com/show_bug.cgi?id=2277925
+  - verifies: https://issues.redhat.com/browse/RHEL-34769
 adjust:
   - enabled: false
     when: distro == rhel-4, rhel-5

diff --git a/selinux-policy/interface-definitions/runtest.sh b/selinux-policy/interface-definitions/runtest.sh
index 6d80041..215404a 100755
--- a/selinux-policy/interface-definitions/runtest.sh
+++ b/selinux-policy/interface-definitions/runtest.sh
@@ -13,6 +13,13 @@ rlJournalStart
         rlRun "grep -i missing output.txt" 1
     rlPhaseEnd
 
+    rlPhaseStartTest "bz#2254169 + bz#2254206 + bz#2277925"
+        rlRun "yum -y reinstall selinux-policy-devel >& output.txt"
+        rlRun "grep -i illegal output.txt" 1
+        rlRun "sepolgen-ifgen --verbose >& output.txt"
+        rlRun "grep -i illegal output.txt" 1
+    rlPhaseEnd
+
     rlPhaseStartCleanup
         rm -f output.txt
     rlPhaseEnd

                 reply	other threads:[~2026-09-11 13:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913289891.1.7094793276627923418.tests-selinux-55c2934207b0@fedoraproject.org \
    --to=mmalik@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox