public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Zdenek Pytela <zpytela@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: Fix incorrect rlIsFedora usage
Date: Fri, 11 Sep 2026 13:21:04 GMT	[thread overview]
Message-ID: <178913286482.1.8817145383430361486.tests-selinux-5f44de3a2137@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : 5f44de3a2137d1ff22f1beed67808712938c7bf2
            Author : Zdenek Pytela <zpytela@redhat.com>
            Date   : 2023-10-18T13:27:52+02:00
            Stats  : +2/-2 in 1 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/5f44de3a2137d1ff22f1beed67808712938c7bf2?branch=pr775-checkpolicy-revdeps

            Log:
            Fix incorrect rlIsFedora usage

Since the ba723f4941c (Update test for virtualization daemons) commit,
the virtualization daemons test branches based on Fedora version, but
rlIsFedora was used incorrectly, making the condition always succeed.

---
diff --git a/selinux-policy/virtualization-daemons/runtest.sh b/selinux-policy/virtualization-daemons/runtest.sh
index f41928a..825382b 100755
--- a/selinux-policy/virtualization-daemons/runtest.sh
+++ b/selinux-policy/virtualization-daemons/runtest.sh
@@ -32,7 +32,7 @@
 PACKAGE="selinux-policy"
 ROOT_PASSWORD="redhat"
 SERVICE_NAMES="libvirtd virtinterfaced virtlockd virtlogd virtlxcd virtnetworkd virtnodedevd virtnwfilterd virtproxyd virtqemud virtsecretd virtstoraged virtvboxd virtxend"
-if rlIsFedora > "39"; then
+if rlIsFedora ">39"; then
 ALL_TUPLES="libvirtd:libvirtd:virtd_t \
             virtinterfaced:virtinterfaced:virtinterfaced_t \
             virtlockd:virtlockd:virtlogd_t \
@@ -86,7 +86,7 @@ rlJournalStart
     rlPhaseEnd
 
     rlPhaseStartTest "SELinux contexts and rules"
-      if rlIsFedora > "39"; then
+      if rlIsFedora ">39"; then
         rlSEMatchPathCon "/usr/sbin/virtinterfaced" "virtinterfaced_exec_t"
         rlSEMatchPathCon "/usr/sbin/virtlxcd" "virtd_lxc_exec_t"
         rlSEMatchPathCon "/usr/sbin/virtnetworkd" "virtnetworkd_exec_t"

                 reply	other threads:[~2026-09-11 13:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913286482.1.8817145383430361486.tests-selinux-5f44de3a2137@fedoraproject.org \
    --to=zpytela@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox