public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Milos Malik <mmalik@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: adapt to [gs]etxattr() which replace l[gs]etxattr()
Date: Fri, 11 Sep 2026 13:20:47 GMT	[thread overview]
Message-ID: <178913284715.1.5992489975602669753.tests-selinux-a32b536cd25b@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : a32b536cd25b4847d5807bc2e9022e0c538db3f5
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2023-06-21T09:24:31+00:00
            Stats  : +27/-26 in 2 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/a32b536cd25b4847d5807bc2e9022e0c538db3f5?branch=pr775-checkpolicy-revdeps

            Log:
            adapt to [gs]etxattr() which replace l[gs]etxattr()

New version of SELinux user-space (3.4) brought a change that affects
this automated test. Functions like lgetxattr and lsetxattr were replaced
by functions getxattr and setxattr.

TBA

---
diff --git a/libselinux/selinux_restorecon-functions/main.fmf b/libselinux/selinux_restorecon-functions/main.fmf
index 528527d..728942e 100644
--- a/libselinux/selinux_restorecon-functions/main.fmf
+++ b/libselinux/selinux_restorecon-functions/main.fmf
@@ -7,6 +7,7 @@ recommend:
   - libselinux
   - libselinux-devel
   - glibc
+  - gcc
   - strace
   - gcc
 enabled: true

diff --git a/libselinux/selinux_restorecon-functions/runtest.sh b/libselinux/selinux_restorecon-functions/runtest.sh
index d5d37ad..b09e6f4 100755
--- a/libselinux/selinux_restorecon-functions/runtest.sh
+++ b/libselinux/selinux_restorecon-functions/runtest.sh
@@ -111,8 +111,8 @@ rlJournalStart
 
         rlRun "strace -ostrace.out -s 64 ./test_restorecon $TmpDir" 0 "Calling selinux_restorecon"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out | grep var_log_t"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out | grep var_log_t" 1
@@ -121,8 +121,8 @@ rlJournalStart
         rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out | grep var_log_t" 1
         rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out | grep var_log_t" 1
         
-        rlLogInfo "Checking lsetxattr calls"
-        rlRun "grep lsetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking setxattr calls"
+        rlRun "grep setxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out | grep user_home_t"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out | grep user_home_t" 1
@@ -143,8 +143,8 @@ rlJournalStart
 
         rlRun "strace -ostrace.out -s 64 ./test_restorecon $TmpDir RECURSE" 0 "Calling selinux_restorecon with RECURSE flag"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out | grep var_log_t"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out | grep var_log_t"
@@ -153,8 +153,8 @@ rlJournalStart
         rlRun "grep \"\\\"$TmpDir/a/bfile\\\"\"     strace_xattr.out | grep var_log_t"
         rlRun "grep \"\\\"$TmpDir/a/b/cfile\\\"\"   strace_xattr.out | grep var_log_t"
 
-        rlLogInfo "Checking lsetxattr calls"
-        rlRun "grep lsetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking setxattr calls"
+        rlRun "grep setxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out | grep user_home_t"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out | grep user_home_t"
@@ -175,8 +175,8 @@ rlJournalStart
 
         rlRun "strace -ostrace.out -s 64 ./test_restorecon $TmpDir RECURSE NOCHANGE" 0 "Calling selinux_restorecon with NOCHANGE flag"
 
-        rlLogInfo "Checking lsetxattr calls"
-        rlRun "grep lsetxattr strace.out" 1
+        rlLogInfo "Checking setxattr calls"
+        rlRun "grep setxattr strace.out" 1
 
         rlRun "rm -f strace.out"
 
@@ -203,8 +203,8 @@ rlJournalStart
         # run restorecon first time
         rlRun "strace -ostrace.out -s 64 ./test_restorecon $TmpDir RECURSE" 0 "Calling selinux_restorecon for the first time"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
@@ -216,8 +216,8 @@ rlJournalStart
         # run restorecon second time
         rlRun "strace -ostrace.out -s 64 ./test_restorecon $TmpDir RECURSE" 0 "Calling selinux_restorecon for the second time"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux" 1
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux" 1
 
         rlRun "rm -f strace.out"
         rlRun "rm -f strace_xattr.out"
@@ -231,8 +231,8 @@ rlJournalStart
         # run restorecon first time
         rlRun "strace -ostrace.out -s 64 ./test_restorecon $TmpDir RECURSE" 0 "Calling selinux_restorecon for the first time"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
@@ -244,8 +244,8 @@ rlJournalStart
         # run restorecon second time
         rlRun "strace -ostrace.out -s 64 ./test_restorecon $TmpDir RECURSE IGNORE_DIGEST" 0 "Calling selinux_restorecon for the second time"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
@@ -266,8 +266,8 @@ rlJournalStart
         # empty exclude list
         rlRun "strace -ostrace.out -s 64 ./test_exclude_list EMPTY $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list with empty list"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
@@ -279,8 +279,8 @@ rlJournalStart
         # exclude $TmpDir/a
         rlRun "strace -ostrace.out -s 64 ./test_exclude_list $TmpDir/a $TmpDir" 0 "Calling selinux_restorecon_set_exclude_list"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out" 1
@@ -301,8 +301,8 @@ rlJournalStart
         # default sehandle
         rlRun "strace -ostrace.out -s 64 ./test_sehandle DEFAULT $TmpDir" 0 "Calling selinux_restorecon_set_sehandle with default handle"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"
@@ -314,8 +314,8 @@ rlJournalStart
         # custom sehandle
         rlRun "strace -ostrace.out -s 64 ./test_sehandle CUSTOM $TmpDir" 0 "Calling selinux_restorecon_set_sehandle with custom handle"
 
-        rlLogInfo "Checking lgetxattr calls"
-        rlRun "grep lgetxattr strace.out | grep security.selinux > strace_xattr.out"
+        rlLogInfo "Checking getxattr calls"
+        rlRun "grep getxattr strace.out | grep security.selinux > strace_xattr.out"
 
         rlRun "grep \"\\\"$TmpDir\\\"\"             strace_xattr.out"
         rlRun "grep \"\\\"$TmpDir/a\\\"\"           strace_xattr.out"

                 reply	other threads:[~2026-09-11 13:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913284715.1.5992489975602669753.tests-selinux-a32b536cd25b@fedoraproject.org \
    --to=mmalik@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox