public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Milos Malik <mmalik@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: require full program locations instead of package names
Date: Fri, 11 Sep 2026 13:20:31 GMT	[thread overview]
Message-ID: <178913283161.1.8642693576723027092.tests-selinux-c020488428db@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : c020488428db50fa0795791dabd5041a0bb439b6
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2023-02-27T12:38:28+01:00
            Stats  : +4/-4 in 3 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/c020488428db50fa0795791dabd5041a0bb439b6?branch=pr775-checkpolicy-revdeps

            Log:
            require full program locations instead of package names

When a program is moved from one package to another package,
automated tests which require the first package may fail. In order
to improve the situation, it's safer to require the full program
location instead of a package name, that may change over time.

---
diff --git a/selinux-policy/cups-browsed-and-similar/Makefile b/selinux-policy/cups-browsed-and-similar/Makefile
index 3986103..951aa63 100644
--- a/selinux-policy/cups-browsed-and-similar/Makefile
+++ b/selinux-policy/cups-browsed-and-similar/Makefile
@@ -55,7 +55,7 @@ $(METADATA): Makefile
 	@echo "TestTime:        15m" >> $(METADATA)
 	@echo "RunFor:          selinux-policy" >> $(METADATA)
 	@echo "RunFor:          cups" >> $(METADATA)
-	@echo "Requires:        audit libselinux libselinux-utils policycoreutils selinux-policy selinux-policy-targeted setools-console cups-filters cups initscripts" >> $(METADATA)
+	@echo "Requires:        audit libselinux libselinux-utils policycoreutils selinux-policy selinux-policy-targeted setools-console /usr/sbin/cups-browsed cups /usr/sbin/service" >> $(METADATA)
 	@echo "RhtsRequires:    library(selinux-policy/common)" >> $(METADATA)
 	@echo "Priority:        Normal" >> $(METADATA)
 	@echo "License:         GPLv2" >> $(METADATA)

diff --git a/selinux-policy/cups-browsed-and-similar/main.fmf b/selinux-policy/cups-browsed-and-similar/main.fmf
index 7e59ea2..d034c54 100644
--- a/selinux-policy/cups-browsed-and-similar/main.fmf
+++ b/selinux-policy/cups-browsed-and-similar/main.fmf
@@ -16,9 +16,9 @@ recommend:
   - selinux-policy
   - selinux-policy-targeted
   - setools-console
-  - cups-filters
+  - /usr/sbin/cups-browsed
   - cups
-  - initscripts
+  - /usr/sbin/service
 environment:
     AVC_ERROR: +no_avc_check
 duration: 15m

diff --git a/selinux-policy/cups-browsed-and-similar/runtest.sh b/selinux-policy/cups-browsed-and-similar/runtest.sh
index 3db7b5c..bba6a10 100755
--- a/selinux-policy/cups-browsed-and-similar/runtest.sh
+++ b/selinux-policy/cups-browsed-and-similar/runtest.sh
@@ -33,7 +33,7 @@ PACKAGE="selinux-policy"
 ROOT_PASSWORD="redhat"
 FILE_PATH="/usr/sbin/cups-browsed"
 FILE_CONTEXT="cupsd_exec_t"
-SERVICE_PACKAGE="cups-filters"
+SERVICE_PACKAGE=`rpm -qf /usr/sbin/cups-browsed`
 SERVICE_NAME="cups-browsed"
 PROCESS_NAME="cups-browsed"
 PROCESS_CONTEXT="cupsd_t"

                 reply	other threads:[~2026-09-11 13:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913283161.1.8642693576723027092.tests-selinux-c020488428db@fedoraproject.org \
    --to=mmalik@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox