public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Ondrej Mosnacek <omosnace@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: semodule-rebuild-if-modules-changed: expand vars early
Date: Fri, 11 Sep 2026 13:20:07 GMT	[thread overview]
Message-ID: <178913280782.1.18037663652416064328.tests-selinux-a77df4275469@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : a77df427546958a8f344c2e1650246d3d9421b33
            Author : Ondrej Mosnacek <omosnace@redhat.com>
            Date   : 2022-08-02T15:03:48+02:00
            Stats  : +6/-6 in 1 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/a77df427546958a8f344c2e1650246d3d9421b33?branch=pr775-checkpolicy-revdeps

            Log:
            semodule-rebuild-if-modules-changed: expand vars early

This will make the test output more explicit.

Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>

---
diff --git a/policycoreutils/semodule-rebuild-if-modules-changed/runtest.sh b/policycoreutils/semodule-rebuild-if-modules-changed/runtest.sh
index 8f55dda..98e84d6 100755
--- a/policycoreutils/semodule-rebuild-if-modules-changed/runtest.sh
+++ b/policycoreutils/semodule-rebuild-if-modules-changed/runtest.sh
@@ -48,22 +48,22 @@ rlJournalStart
                 "Make sure policy store is in a consistent state initially"
 
             rlLog "Inject a new module into the store"
-            rlRun "mkdir -p \"\$TEST_MODULE_DIR\""
-            rlRun "echo -n cil >\"\$TEST_MODULE_DIR/lang_ext\""
-            rlRun "echo '(type test_module_type_t)' >\"\$TEST_MODULE_DIR/cil\""
+            rlRun "mkdir -p '$TEST_MODULE_DIR'"
+            rlRun "echo -n cil >'$TEST_MODULE_DIR/lang_ext'"
+            rlRun "echo '(type test_module_type_t)' >'$TEST_MODULE_DIR/cil'"
             rlRun "semodule -N --rebuild-if-modules-changed" 0 \
                 "Do a conditional rebuild"
             rlRun "semodule -l | grep test_module" 0 \
                 "Verify that the module has been picked up"
-            rlRun "seinfo -t test_module_type_t \"\$STORE_POLICY\" | grep test_module_type_t" 0 \
+            rlRun "seinfo -t test_module_type_t '$STORE_POLICY' | grep test_module_type_t" 0 \
                 "Verify that the new type is included in the built policy"
 
             rlLog "Now remove the module"
-            rlRun "rm -rf \"\$TEST_MODULE_DIR\""
+            rlRun "rm -rf '$TEST_MODULE_DIR'"
             rlRun "semodule -N --rebuild-if-modules-changed"
             rlRun "semodule -l | grep test_module" 1 \
                 "Verify that the module has been removed"
-            rlRun "seinfo -t test_module_type_t \"\$STORE_POLICY\" | grep test_module_type_t" 1 \
+            rlRun "seinfo -t test_module_type_t '$STORE_POLICY' | grep test_module_type_t" 1 \
                 "Verify that the new type is NOT included in the built policy"
 
             # Make sure policy is restored regardless of any previous failures

                 reply	other threads:[~2026-09-11 13:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913280782.1.18037663652416064328.tests-selinux-a77df4275469@fedoraproject.org \
    --to=omosnace@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox