public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Milos Malik <mmalik@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: exit the tests if their required services are missing
Date: Fri, 11 Sep 2026 13:19:32 GMT	[thread overview]
Message-ID: <178913277213.1.13653001345983741222.tests-selinux-df22c3b60bee@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : df22c3b60beedc937afff4a67a8f9c2a2f9faf7f
            Author : Milos Malik <mmalik@redhat.com>
            Date   : 2022-01-12T11:43:03+01:00
            Stats  : +2/-3 in 2 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/df22c3b60beedc937afff4a67a8f9c2a2f9faf7f?branch=pr775-checkpolicy-revdeps

            Log:
            exit the tests if their required services are missing

Services like systemd-homed and systemd-userdbd are available on Fedora,
but they are not available on RHEL. It makes no sense to run their tests
in environments, where the services are not available. Without these
services being present the tests would fail.

---
diff --git a/selinux-policy/systemd-homed/runtest.sh b/selinux-policy/systemd-homed/runtest.sh
index 975bf39..3357cae 100755
--- a/selinux-policy/systemd-homed/runtest.sh
+++ b/selinux-policy/systemd-homed/runtest.sh
@@ -110,7 +110,7 @@ expect -f  - <<<'
 }
 
 rlJournalStart
-    if rlIsRHEL '<9' ; then
+    if [ ! -f /usr/lib/systemd/systemd-homed ] ; then
         rlLog "Not applicable to this OS version."
         rlJournalEnd
         exit 0

diff --git a/selinux-policy/systemd-userdbd-and-similar/runtest.sh b/selinux-policy/systemd-userdbd-and-similar/runtest.sh
index f817604..8a439ea 100755
--- a/selinux-policy/systemd-userdbd-and-similar/runtest.sh
+++ b/selinux-policy/systemd-userdbd-and-similar/runtest.sh
@@ -42,8 +42,7 @@ ALLOWED_USERS=${ALLOWED_USERS:-"staff_u user_u guest_u xguest_u sysadm_u unconfi
 DENIED_USERS=${DENIED_USERS:-""}
 
 rlJournalStart
-    # the systemd-userdbd service is not available on RHEL-8
-    if rlIsRHEL 8 ; then
+    if [ ! -f /usr/lib/systemd/systemd-userdbd ] ; then
         rlLog "Not applicable to this OS version."
         rlJournalEnd
         exit 0

                 reply	other threads:[~2026-09-11 13:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913277213.1.13653001345983741222.tests-selinux-df22c3b60bee@fedoraproject.org \
    --to=mmalik@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox