public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Ondrej Mosnacek <omosnace@redhat.com>
To: git-commits@fedoraproject.org
Subject: [tests/selinux] pr775-checkpolicy-revdeps: test-pr: Fix behavior when branch is not rebased
Date: Fri, 11 Sep 2026 13:18:05 GMT	[thread overview]
Message-ID: <178913268592.1.13446404390482921380.tests-selinux-f80b045d097d@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : tests/selinux
            Branch : pr775-checkpolicy-revdeps
            Commit : f80b045d097d953bd40e0849e67a2a80604f9adb
            Author : Ondrej Mosnacek <omosnace@redhat.com>
            Date   : 2020-08-12T08:02:56+00:00
            Stats  : +1/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/tests/selinux/c/f80b045d097d953bd40e0849e67a2a80604f9adb?branch=pr775-checkpolicy-revdeps

            Log:
            test-pr: Fix behavior when branch is not rebased

Since the current command simply compares the PR's HEAD with the master
branch, it will include any new changes in master as modified tests and
run tests on them as well.

Fix it by using `git log` on `origin/master..HEAD`, which will return
files modified by commits in the PR branch which are not part of master,
which is what we really want.

Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>

---
diff --git a/tests-pr.yml b/tests-pr.yml
index 7d04192..f1e7fab 100644
--- a/tests-pr.yml
+++ b/tests-pr.yml
@@ -5,7 +5,7 @@
   pre_tasks:
     - name: Generate list of tests in this PR
       shell: |
-          git diff --stat --name-only origin/master HEAD | sed '/\//!d;s#\(.*\)/.*#\1#' | sort -u | xargs
+          git log --format= --stat --name-only origin/master..HEAD | sed '/\//!d;s#\(.*\)/.*#\1#' | sort -u | xargs
       delegate_to: localhost
       register: tests_list
 

                 reply	other threads:[~2026-09-11 13:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178913268592.1.13446404390482921380.tests-selinux-f80b045d097d@fedoraproject.org \
    --to=omosnace@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox