public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowi@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/flatpak-runtime-config] f45: Remove package notes from flatpak-builder compile flags
Date: Thu, 10 Sep 2026 21:21:50 GMT	[thread overview]
Message-ID: <178907531037.1.4730065347747117729.rpms-flatpak-runtime-config-025c396a8926@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/flatpak-runtime-config
            Branch : f45
            Commit : 025c396a8926565d62068796f537d35f7f366629
            Author : Yaakov Selkowitz <yselkowi@redhat.com>
            Date   : 2023-02-20T21:11:11-05:00
            Stats  : +8/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/flatpak-runtime-config/c/025c396a8926565d62068796f537d35f7f366629?branch=f45

            Log:
            Remove package notes from flatpak-builder compile flags

As implemented in redhat-rpm-config, package notes requires several
RPM-specific environment variables to be set, and therefore only work
with RPM builds.  This causes gcc to be unable to compile in other use
cases, such as with flatpak-builder.

---
diff --git a/flatpak-runtime-config.spec b/flatpak-runtime-config.spec
index 7dc530a..6c4e2b0 100644
--- a/flatpak-runtime-config.spec
+++ b/flatpak-runtime-config.spec
@@ -1,6 +1,10 @@
+# package notes require setting RPM-specific environment variables,
+# incompatible with flatpak-builder
+%undefine _package_note_flags
+
 Name:           flatpak-runtime-config
 Version:        37
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Configuration files that live inside the flatpak runtime
 Source1:        50-flatpak.conf
 Source2:        usercustomize.py
@@ -86,6 +90,9 @@ HOME=/root /usr/bin/fc-cache -s
 %{_sysconfdir}/ld.so.conf.d/app.conf
 
 %changelog
+* Tue Feb 21 2023 Yaakov Selkowitz <yselkowi@redhat.com> - 37-3
+- Remove package notes from flatpak-builder compile flags
+
 * Tue Sep 06 2022 Kalev Lember <klember@redhat.com> - 37-2
 - Correctly substitute /app/lib in flatpak-builder defaults.json ldflags
 - Revert "Fix search paths for /app-installed python modules" (#2026979)

                 reply	other threads:[~2026-09-10 21:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178907531037.1.4730065347747117729.rpms-flatpak-runtime-config-025c396a8926@fedoraproject.org \
    --to=yselkowi@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox