public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Benjamin A. Beasley <code@musicinmybrain.net>
To: git-commits@fedoraproject.org
Subject: [rpms/abseil-cpp] rawhide: Don’t be explicit about the ninja backend for the native build
Date: Wed, 09 Sep 2026 17:13:33 GMT	[thread overview]
Message-ID: <178897401313.1.2730403003167769804.rpms-abseil-cpp-711cad1b7ce1@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/abseil-cpp
            Branch : rawhide
            Commit : 711cad1b7ce1ee05151b3bc707652929e79ebb7c
            Author : Benjamin A. Beasley <code@musicinmybrain.net>
            Date   : 2026-09-09T13:07:15+01:00
            Stats  : +6/-6 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/abseil-cpp/c/711cad1b7ce1ee05151b3bc707652929e79ebb7c?branch=rawhide

            Log:
            Don’t be explicit about the ninja backend for the native build

It’s now the default, so we don’t have to.

[skip changelog]

---
diff --git a/abseil-cpp.spec b/abseil-cpp.spec
index 09362b0..4b8dee8 100644
--- a/abseil-cpp.spec
+++ b/abseil-cpp.spec
@@ -34,9 +34,12 @@ Source:         https://github.com/abseil/abseil-cpp/archive/%{version}/abseil-c
 Patch:          https://github.com/abseil/abseil-cpp/commit/d851fdd768b27c02b3fb786fd0987faddd279ece.patch
 
 BuildRequires:  cmake
-# The default make backend would work just as well; ninja is observably faster
-BuildRequires:  ninja-build
 BuildRequires:  gcc-c++
+# The ninja backend for CMake (which is observably faster than the UNIX
+# Makefiles backend) is the default since
+# https://fedoraproject.org/wiki/Changes/CMake_ninja_default; we choose to
+# be explicit since the MinGW build uses a ninja-specific macro.
+BuildRequires:  ninja-build
 
 BuildRequires:  gmock-devel
 BuildRequires:  gtest-devel
@@ -130,7 +133,6 @@ MinGW Windows abseil-cpp library.
 # subpackage when tests are not enabled. It is therefore redundant here, but we
 # still supply it to be more explicit.
 %cmake \
-    -GNinja \
     -DABSL_USE_EXTERNAL_GOOGLETEST:BOOL=ON \
     -DABSL_FIND_GOOGLETEST:BOOL=ON \
     -DABSL_ENABLE_INSTALL:BOOL=ON \
@@ -141,9 +143,7 @@ MinGW Windows abseil-cpp library.
 %cmake_build
 
 %if %{with mingw}
-%mingw_cmake \
-    -DABSL_BUILD_TESTING:BOOL=OFF \
-    -GNinja
+%mingw_cmake -GNinja -DABSL_BUILD_TESTING:BOOL=OFF
 %mingw_ninja --verbose
 %endif
 

                 reply	other threads:[~2026-09-09 17:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178897401313.1.2730403003167769804.rpms-abseil-cpp-711cad1b7ce1@fedoraproject.org \
    --to=code@musicinmybrain.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox