public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/nodejs-undici] f45: Address rpmlint issues
Date: Tue, 08 Sep 2026 14:27:23 GMT [thread overview]
Message-ID: <178887764351.1.13421489369623279025.rpms-nodejs-undici-90babdc6e92e@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/nodejs-undici
Branch : f45
Commit : 90babdc6e92e12d7080be4f953b3b2f6654f57c4
Author : Jan Staněk <jstanek@redhat.com>
Date : 2026-09-08T15:36:33+02:00
Stats : +12/-2 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/nodejs-undici/c/90babdc6e92e12d7080be4f953b3b2f6654f57c4?branch=f45
Log:
Address rpmlint issues
- Clean up packaging to get rid of unneeded empty files and symlinks
- Filter rpmlint issues that are either expected or not relevant in
nodejs packaging
---
diff --git a/nodejs-undici.rpmlintrc b/nodejs-undici.rpmlintrc
new file mode 100644
index 0000000..19a7c1b
--- /dev/null
+++ b/nodejs-undici.rpmlintrc
@@ -0,0 +1,4 @@
+# bundled sources from script are expected
+addFilter(r"\binvalid-url Source.: undici-.*-(stripped|nm-prod|nm-dev)\.(tar\.gz|tgz)")
+# all node/npm packages are installed under /usr/lib/node_modules, even if they contain no arch-specific files
+addFilter(r"only-non-binary-in-usr-lib")
diff --git a/nodejs-undici.spec b/nodejs-undici.spec
index b121a24..3d9e052 100644
--- a/nodejs-undici.spec
+++ b/nodejs-undici.spec
@@ -61,10 +61,15 @@ then
fi
# Link node_modules
-mkdir -p node_modules/.bin/
+mkdir -p node_modules/
tar -xzf %{S:1}
ln -srt node_modules/ node_modules_prod/*
-ln -srt node_modules/.bin/ node_modules_prod/.bin
+test ! -d node_modules_prod/.bin || ln -srt node_modules/ node_modules_prod/.bin
+
+# Clean extraneous files we do not need to package
+find . -type f -name '.gitkeep' -size 0 -delete
+# https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json?v=true#hidden-lockfiles
+rm -f node_modules_prod/.package-lock.json
%build
export WASM_CC=clang
@@ -93,6 +98,7 @@ install -p -Dt %{buildroot}%{nodejs_sitelib}/%{npm_name}/ loader.js
tar -xzf %{S:2}
ln -fsrt node_modules/ node_modules_dev/*
+test -d node_modules/.bin || mkdir node_modules/.bin
ln -fsrt node_modules/.bin/ node_modules_dev/.bin/*
# Built-in test run using borp. Some tests are ignored on purpose.
reply other threads:[~2026-09-08 14:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178887764351.1.13421489369623279025.rpms-nodejs-undici-90babdc6e92e@fedoraproject.org \
--to=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox