public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Pavel Valena <pvalena@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/dracut] rawhide: batch of fixes 2026-09-07
Date: Tue, 08 Sep 2026 00:31:28 GMT [thread overview]
Message-ID: <178882748852.1.2059450354401441393.rpms-dracut-123bb6a8e150@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/dracut
Branch : rawhide
Commit : 123bb6a8e150777605d27b96e4662c7862d8719b
Author : Pavel Valena <pvalena@redhat.com>
Date : 2026-09-07T23:57:52+02:00
Stats : +118/-2 in 3 file(s)
URL : https://src.fedoraproject.org/rpms/dracut/c/123bb6a8e150777605d27b96e4662c7862d8719b?branch=rawhide
Log:
batch of fixes 2026-09-07
- fix(dracut-install): remove FTS_NOSTAT in install_modules() fts traversal
- fix(drm): add leds-qcom-lpg to aarch64 specific modules needed by drm
From-source-git-commit: 43156a656e4df68e8f51a35de7910eb8e3bb99ae
---
diff --git a/0021-fix-dracut-install-remove-FTS_NOSTAT-in-install_modu.patch b/0021-fix-dracut-install-remove-FTS_NOSTAT-in-install_modu.patch
new file mode 100644
index 0000000..049a22b
--- /dev/null
+++ b/0021-fix-dracut-install-remove-FTS_NOSTAT-in-install_modu.patch
@@ -0,0 +1,49 @@
+From 864916070610cb883f841ecdb291f9c74046692c Mon Sep 17 00:00:00 2001
+From: Josh Poimboeuf <jpoimboe@kernel.org>
+Date: Wed, 15 Apr 2026 10:21:07 -0700
+Subject: [PATCH 21/22] fix(dracut-install): remove FTS_NOSTAT in
+ install_modules() fts traversal
+
+install_modules() uses FTS_NOSTAT when traversing kernel module
+directories. With FTS_NOSTAT, fts may skip stat() and report regular
+files as FTS_NSOK instead of FTS_F. However, the fts_info check only
+accepts FTS_F and FTS_SL, causing all .ko files found this way to be
+silently skipped.
+
+This was previously masked by glibc's fts implementation which ignored
+FTS_NOSTAT when FTS_LOGICAL was also set, always calling stat and
+returning FTS_F. A recent glibc change (commit 99303f3871, "io: Use
+gnulib fts implementation") now honors FTS_NOSTAT regardless, exposing
+this bug.
+
+The result is that all '=directory' pattern module installs (=drivers,
+=crypto, =fs, etc.) find zero modules, producing an initramfs with only
+explicitly-named modules (~40 instead of ~500+), which typically fails
+to boot.
+
+Fix it by removing FTS_NOSTAT so that fts always stats files and
+reliably reports actual file types.
+
+(cherry picked from commit 5cf89590c28f3ffddc64791b2059ba4ea64b4b44)
+
+Related: RHBZ#2457183
+---
+ src/install/dracut-install.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/install/dracut-install.c b/src/install/dracut-install.c
+index efa64306e..ac70b8dd7 100644
+--- a/src/install/dracut-install.c
++++ b/src/install/dracut-install.c
+@@ -2708,7 +2708,7 @@ static int install_modules(int argc, char **argv)
+
+ {
+ char *paths[] = { path1, path2, path3, NULL };
+- fts = fts_open(paths, FTS_COMFOLLOW | FTS_NOCHDIR | FTS_NOSTAT | FTS_LOGICAL, NULL);
++ fts = fts_open(paths, FTS_COMFOLLOW | FTS_NOCHDIR | FTS_LOGICAL, NULL);
+ }
+
+ for (FTSENT *ftsent = fts_read(fts); ftsent != NULL; ftsent = fts_read(fts)) {
+--
+2.55.0
+
diff --git a/0022-fix-drm-add-leds-qcom-lpg-to-aarch64-specific-module.patch b/0022-fix-drm-add-leds-qcom-lpg-to-aarch64-specific-module.patch
new file mode 100644
index 0000000..86162e0
--- /dev/null
+++ b/0022-fix-drm-add-leds-qcom-lpg-to-aarch64-specific-module.patch
@@ -0,0 +1,55 @@
+From 43156a656e4df68e8f51a35de7910eb8e3bb99ae Mon Sep 17 00:00:00 2001
+From: Hans de Goede <johannes.goede@oss.qualcomm.com>
+Date: Thu, 3 Sep 2026 22:52:37 +0200
+Subject: [PATCH 22/22] fix(drm): add leds-qcom-lpg to aarch64 specific modules
+ needed by drm
+
+Upstream: https://github.com/dracut-ng/dracut/pull/2721
+
+Currently F45 aarch64 isos have a black display during the initramfs phase
+of boot on Windows on ARM laptops. This is caused by a missing pwm driver
+for the LCD backlight. Things work once the system switches to the rootfs
+with all modules, but users end up looking at a black screen for quite
+a while (30 sec - 1 min) and that is when not doing the default selected
+media check on the live isos. With the media check the screen is black
+during the entire media-check (easily a couple of minutes) making
+the system look dead. And if the media check stops on a failure then this
+will not be visible.
+
+This fix has been end-to-end tested on a ThinkPad T14s gen6 Snapdragon by
+including "packit build locally" rpms into a Fedora 45 aarch64 kiwi
+Workstation-Live image build and testing that image.
+
+Upstream commit message:
+
+leds-qcom-lpg is not only a LED class driver but it can also be a pwm class
+driver and sometimes its pwm function is used for panel backlight control
+in which case it is needed for drm/kms to work.
+
+Since leds-qcom-lpg lives under drivers/leds/rgb/ it is not automatically
+picked-up by the existing 'instmods "=drivers/pwm"', add it explicitly
+to the instmods argument to get it included into the initramfs.
+
+This follows the pattern of how the amdkfd and hyperv_fb special cases are
+already handled.
+
+Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
+---
+ modules.d/45drm/module-setup.sh | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/modules.d/45drm/module-setup.sh b/modules.d/45drm/module-setup.sh
+index 45a458681..966d4180f 100755
+--- a/modules.d/45drm/module-setup.sh
++++ b/modules.d/45drm/module-setup.sh
+@@ -12,6 +12,7 @@ installkernel() {
+ if [[ ${DRACUT_ARCH} == arm* || ${DRACUT_ARCH} == aarch64 ]]; then
+ # arm/aarch64 specific modules needed by drm
+ hostonly=$(optional_hostonly) instmods \
++ leds-qcom-lpg \
+ "=drivers/gpu/drm/i2c" \
+ "=drivers/gpu/drm/panel" \
+ "=drivers/gpu/drm/bridge" \
+--
+2.55.0
+
diff --git a/dracut.spec b/dracut.spec
index 8cf3146..cce388d 100644
--- a/dracut.spec
+++ b/dracut.spec
@@ -8,7 +8,7 @@
Name: dracut
Version: 111
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: Initramfs generator using udev
@@ -82,6 +82,12 @@ Patch19: 0019-fix-devicetree-firmware-include-soc-specific-firmwar.patch
# fix(devicetree-firmware): include Qualcomm X2 laptop model specific firmwares
# Author: Hans de Goede <johannes.goede@oss.qualcomm.com>
Patch20: 0020-fix-devicetree-firmware-include-Qualcomm-X2-laptop-m.patch
+# fix(dracut-install): remove FTS_NOSTAT in install_modules() fts traversal
+# Author: Josh Poimboeuf <jpoimboe@kernel.org>
+Patch21: 0021-fix-dracut-install-remove-FTS_NOSTAT-in-install_modu.patch
+# fix(drm): add leds-qcom-lpg to aarch64 specific modules needed by drm
+# Author: Hans de Goede <johannes.goede@oss.qualcomm.com>
+Patch22: 0022-fix-drm-add-leds-qcom-lpg-to-aarch64-specific-module.patch
# Please use source-git to work with this spec file:
# HowTo: https://packit.dev/source-git/work-with-source-git
@@ -529,6 +535,12 @@ echo 'dracut_rescue_image="yes"' > $RPM_BUILD_ROOT%{dracutlibdir}/dracut.conf.d/
%{_prefix}/lib/kernel/install.d/51-dracut-rescue.install
%changelog
+* Fri Sep 11 2026 Hans de Goede <johannes.goede@oss.qualcomm.com> - 111-3
+- fix(drm): add leds-qcom-lpg to aarch64 specific modules needed by drm
+
+* Fri Sep 04 2026 Pavel Valena <pvalena@redhat.com> - 111-3
+- fix(dracut-install): remove FTS_NOSTAT in install_modules() fts traversal
+
* Tue Aug 18 2026 Hans de Goede <johannes.goede@oss.qualcomm.com> - 111-2
- fix(devicetree-firmware): include soc specific firmwares in install_generic()
- fix(devicetree-firmware): include Qualcomm X2 laptop model specific firmwares
@@ -538,7 +550,7 @@ echo 'dracut_rescue_image="yes"' > $RPM_BUILD_ROOT%{dracutlibdir}/dracut.conf.d/
- fix(base): replace eval with safe variable indirection in splitsep and export_n
- spec: json support for dracut-install (needed for detecting dlopen dependencies)
-* Mon aug 10 2026 Hans de Goede <johannes.goede@oss.qualcomm.com> - 111-2
+* Mon Aug 10 2026 Hans de Goede <johannes.goede@oss.qualcomm.com> - 111-2
- feat(dracut): add module to load Qualcomm ADSP module pre-udev
* Fri Jul 31 2026 Pavel Valena <pvalena@redhat.com> - 111-1
reply other threads:[~2026-09-08 0:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178882748852.1.2059450354401441393.rpms-dracut-123bb6a8e150@fedoraproject.org \
--to=pvalena@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox