public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Mamoru TASAKA <mtasaka@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/ugene] git-develop: Fix signness for qmin on 32bit
Date: Sun, 06 Sep 2026 07:47:36 GMT	[thread overview]
Message-ID: <178868085657.1.7872374190151696726.rpms-ugene-8e82a0c71cb9@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/ugene
Branch : git-develop
Commit : 8e82a0c71cb9057d0dcd08d3638337982302a081
Author : Mamoru TASAKA <mtasaka@fedoraproject.org>
Date   : 2026-09-06T16:47:27+09:00
Stats  : +20/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/ugene/c/8e82a0c71cb9057d0dcd08d3638337982302a081?branch=git-develop

Log:
Fix signness for qmin on 32bit

---
diff --git a/ugene-53.1.x-qmin-arg-signness.patch b/ugene-53.1.x-qmin-arg-signness.patch
new file mode 100644
index 0000000..5e3b0f1
--- /dev/null
+++ b/ugene-53.1.x-qmin-arg-signness.patch
@@ -0,0 +1,17 @@
+diff --git a/src/plugins/pcr/src/InSilicoPcrTask.cpp b/src/plugins/pcr/src/InSilicoPcrTask.cpp
+index c2e106cd9..a5febc83e 100644
+--- a/src/plugins/pcr/src/InSilicoPcrTask.cpp
++++ b/src/plugins/pcr/src/InSilicoPcrTask.cpp
+@@ -66,10 +66,10 @@ namespace {
+ int getMaxError(const InSilicoPcrTaskSettings* settings, U2Strand::Direction direction) {
+     int res = 0;
+     if (direction == U2Strand::Direct) {
+-        res = qMin((qsizetype)settings->forwardMismatches, settings->forwardPrimer.length() - settings->perfectMatch);
++        res = qMin((qsizetype)settings->forwardMismatches, settings->forwardPrimer.length() - (qsizetype)settings->perfectMatch);
+         res = qMin(res, settings->forwardPrimer.length() - 1);
+     } else {
+-        res = qMin((qsizetype)settings->reverseMismatches, settings->reversePrimer.length() - settings->perfectMatch);
++        res = qMin((qsizetype)settings->reverseMismatches, settings->reversePrimer.length() - (qsizetype)settings->perfectMatch);
+         res = qMin(res, settings->reversePrimer.length() - 1);
+     }
+     return qMax(0, res);

diff --git a/ugene.spec b/ugene.spec
index f015be8..e187721 100644
--- a/ugene.spec
+++ b/ugene.spec
@@ -73,6 +73,7 @@ Source2:	create-%{name}-git-bare-tarball.sh
 Source10:	ugene.wrapper
 Patch1:	ugene-49.1-narrowing-for-unsigned-char.patch
 Patch3:	ugene-52.1.x-QObject-connect-overload.patch
+Patch4:	ugene-53.1.x-qmin-arg-signness.patch
 # Currently distro-specific
 Patch102:	ugene-44.x-libs_3rdparty-breakpad-sys_mmap_use_system_mmap.patch
 Patch103:	ugene-40.1-libs_3rdparty-breakpad-unwind-nonsupported-arch.patch
@@ -141,6 +142,8 @@ git config user.email "%{name}-maintainers@fedoraproject.org"
 	%GIT commit -m "Fix narrowing on arch where default char is unsigned" -a
 %patch -P3 -p1 -b .include
 	%GIT commit -m "RegionSelectorController: specify overloaded function" -a
+%patch -P4 -p1 -b .signness
+	%GIT commit -m "Fix signness for qMin argument" -a
 %patch -P102 -p1 -b .sys_mmap -Z
 	%GIT commit -m "libs_3rdparty/breakpad: use C function instead of directly using syscall assemble code" -a
 %patch -P103 -p1 -b .unwind -Z

                 reply	other threads:[~2026-09-06  7:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178868085657.1.7872374190151696726.rpms-ugene-8e82a0c71cb9@fedoraproject.org \
    --to=mtasaka@fedoraproject.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox