public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Benjamin A. Beasley <code@musicinmybrain.net>
To: git-commits@fedoraproject.org
Subject: [rpms/rapidyaml] f45: Patch for cmake not finding c4core dep.: fix RHBZ#2517507
Date: Sat, 05 Sep 2026 08:04:17 GMT	[thread overview]
Message-ID: <178859545778.1.5075214791674315836.rpms-rapidyaml-93f4b116af2b@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/rapidyaml
Branch : f45
Commit : 93f4b116af2be1e5b7998ada5c75d03fd97af1e9
Author : Benjamin A. Beasley <code@musicinmybrain.net>
Date   : 2026-09-05T08:45:01+01:00
Stats  : +37/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/rapidyaml/c/93f4b116af2be1e5b7998ada5c75d03fd97af1e9?branch=f45

Log:
Patch for cmake not finding c4core dep.: fix RHBZ#2517507

---
diff --git a/662.patch b/662.patch
new file mode 100644
index 0000000..8f9e13d
--- /dev/null
+++ b/662.patch
@@ -0,0 +1,27 @@
+From b4d80b0e89bde09ec7d6333777fcf17405a532bd Mon Sep 17 00:00:00 2001
+From: "Benjamin A. Beasley" <code@musicinmybrain.net>
+Date: Sat, 5 Sep 2026 08:01:18 +0100
+Subject: [PATCH] Fix `c4_install_exports` call with system `c4core`
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes #659. Based on a suggestion by Sébastien Noel (@twolife) in a
+comment on that issue.
+---
+ CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 285dc9937..b482a75ea 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -200,7 +200,7 @@ endif()
+ 
+ if(RYML_INSTALL)
+     c4_install_target(ryml)
+-    if(RYML_STANDALONE OR RYML_SYSTEM_C4CORE)
++    if(RYML_STANDALONE AND NOT RYML_SYSTEM_C4CORE)
+         c4_install_exports()
+     else()
+         c4_install_exports(DEPENDENCIES c4core)

diff --git a/rapidyaml.spec b/rapidyaml.spec
index 2155a13..d48729f 100644
--- a/rapidyaml.spec
+++ b/rapidyaml.spec
@@ -39,6 +39,16 @@ Source10:       patch-no-download
 # cmake: fix test linking with c4core when using RYML_SYSTEM_C4CORE
 # https://github.com/biojppm/rapidyaml/pull/653
 Patch:          %{url}/pull/653.patch
+# Fix `c4_install_exports` call with system `c4core`
+# https://github.com/biojppm/rapidyaml/pull/662
+#
+# Fixes:
+#
+# Missing find_package() for c4core with RYML_SYSTEM_C4CORE=ON?
+# https://github.com/biojppm/rapidyaml/issues/659
+# CMake configuration fails due to missing c4core dependency
+# https://bugzilla.redhat.com/show_bug.cgi?id=2517507
+Patch:          %{url}/pull/662.patch
 
 BuildSystem:    cmake
 # Disable RYML_FUZZ_TEST so that we do not have to include the contents of

                 reply	other threads:[~2026-09-05  8:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178859545778.1.5075214791674315836.rpms-rapidyaml-93f4b116af2b@fedoraproject.org \
    --to=code@musicinmybrain.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox