public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowi@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/open-vm-tools] rawhide: Fix build with GCC 15
Date: Thu, 03 Sep 2026 15:05:37 GMT	[thread overview]
Message-ID: <178844793780.1.1774238748001209926.rpms-open-vm-tools-c55679b84895@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/open-vm-tools
            Branch : rawhide
            Commit : c55679b84895175043a9123a7e256ce426508a32
            Author : Yaakov Selkowitz <yselkowi@redhat.com>
            Date   : 2025-03-20T13:31:02-04:00
            Stats  : +25/-0 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/open-vm-tools/c/c55679b84895175043a9123a7e256ce426508a32?branch=rawhide

            Log:
            Fix build with GCC 15

GCC 15 defaults to C23, in which the interpretation of function
declarations without parameters has changed from unspecified (as in K&R) to
`void`.  This fix has been accepted upstream.

https://github.com/vmware/open-vm-tools/pull/751

---
diff --git a/751.patch b/751.patch
new file mode 100644
index 0000000..4529fca
--- /dev/null
+++ b/751.patch
@@ -0,0 +1,23 @@
+From 129d87bd5fd5f2436a467d4b7d43e0d102a867da Mon Sep 17 00:00:00 2001
+From: Rudi Heitbaum <rudi@heitbaum.com>
+Date: Wed, 20 Nov 2024 10:40:03 +1100
+Subject: [PATCH] Fix build when compiling with -std=c23
+
+Fixes the build when using gcc 15
+---
+ open-vm-tools/lib/lock/ul.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/open-vm-tools/lib/lock/ul.c b/open-vm-tools/lib/lock/ul.c
+index d376a98af..fc9fdb714 100644
+--- a/open-vm-tools/lib/lock/ul.c
++++ b/open-vm-tools/lib/lock/ul.c
+@@ -29,7 +29,7 @@
+ static Bool mxInPanic = FALSE;  // track when involved in a panic
+ static Bool mxUserCollectLockingTree = FALSE;
+ 
+-Bool (*MXUserTryAcquireForceFail)() = NULL;
++Bool (*MXUserTryAcquireForceFail)(const char *) = NULL;
+ 
+ static MX_Rank (*MXUserMxCheckRank)(void) = NULL;
+ static void (*MXUserMxLockLister)(void) = NULL;

diff --git a/open-vm-tools.spec b/open-vm-tools.spec
index 31e7396..801a4c6 100644
--- a/open-vm-tools.spec
+++ b/open-vm-tools.spec
@@ -78,6 +78,8 @@ ExclusiveArch:    %{ix86} x86_64 aarch64
 
 # Patches
 #Patch0:           <patch-name0>.patch
+# Fix build when compiling with -std=c23 (GCC 15)
+Patch1:           https://github.com/vmware/open-vm-tools/pull/751.patch
 
 BuildRequires:    autoconf
 BuildRequires:    automake

                 reply	other threads:[~2026-09-03 15:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178844793780.1.1774238748001209926.rpms-open-vm-tools-c55679b84895@fedoraproject.org \
    --to=yselkowi@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox