public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Rafael Fontenelle <rafaelff@gnome.org>
To: git-commits@fedoraproject.org
Subject: [rpms/ddnet] exclude-empty-files: Add 0003-let-dbg_assert-format-the-string.patch
Date: Thu, 03 Sep 2026 00:10:32 GMT	[thread overview]
Message-ID: <178839423260.1.14446605925976453985.rpms-ddnet-bb8defcee822@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/ddnet
Branch : exclude-empty-files
Commit : bb8defcee822769dfe9fbae0f9a6318b067b9029
Author : Rafael Fontenelle <rafaelff@gnome.org>
Date   : 2025-04-03T01:47:45+00:00
Stats  : +41/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/ddnet/c/bb8defcee822769dfe9fbae0f9a6318b067b9029?branch=exclude-empty-files

Log:
Add 0003-let-dbg_assert-format-the-string.patch

---
diff --git a/0003-let-dbg_assert-format-the-string.patch b/0003-let-dbg_assert-format-the-string.patch
new file mode 100644
index 0000000..dafc6b1
--- /dev/null
+++ b/0003-let-dbg_assert-format-the-string.patch
@@ -0,0 +1,38 @@
+From 7b9a9f231868c1cb0e7b413f39b5d26f9964f1e9 Mon Sep 17 00:00:00 2001
+From: BlaiZephyr <arbeit.t.lechner@gmail.com>
+Date: Sat, 29 Mar 2025 23:20:53 +0100
+Subject: [PATCH] let dbg_assert format the string
+
+---
+ src/base/system.cpp               | 4 +---
+ src/engine/client/backend_sdl.cpp | 2 +-
+ 2 files changed, 2 insertions(+), 4 deletions(-)
+
+diff --git a/src/base/system.cpp b/src/base/system.cpp
+index 75a76de4309..7daf1528d82 100644
+--- a/src/base/system.cpp
++++ b/src/base/system.cpp
+@@ -1166,9 +1166,7 @@ void net_addr_str(const NETADDR *addr, char *string, int max_length, bool add_po
+ 	}
+ 	else
+ 	{
+-		char error[64];
+-		str_format(error, sizeof(error), "unknown NETADDR type %d", addr->type);
+-		dbg_assert(false, error);
++		dbg_assert(false, "unknown NETADDR type %d", addr->type);
+ 	}
+ }
+ 
+diff --git a/src/engine/client/backend_sdl.cpp b/src/engine/client/backend_sdl.cpp
+index 48c5c420d5e..00d041c16d3 100644
+--- a/src/engine/client/backend_sdl.cpp
++++ b/src/engine/client/backend_sdl.cpp
+@@ -165,7 +165,7 @@ void CGraphicsBackend_Threaded::ProcessError(const SGfxErrorContainer &Error)
+ 		else
+ 			VerboseStr.append(ErrStr.m_Err);
+ 	}
+-	dbg_assert(false, VerboseStr.c_str());
++	dbg_assert(false, "%s", VerboseStr.c_str());
+ }
+ 
+ bool CGraphicsBackend_Threaded::GetWarning(std::vector<std::string> &WarningStrings)

diff --git a/ddnet.spec b/ddnet.spec
index 73cf35b..b5fdb23 100644
--- a/ddnet.spec
+++ b/ddnet.spec
@@ -39,6 +39,9 @@ Source0:        https://github.com/ddnet/ddnet/archive/%{version}/%{name}-%{vers
 Patch1:         0001-Disabled-network-lookup-test.patch
 # Unbundle md5 and json-parser
 Patch2:         0002-Unbundle-md5_and_json-parser.patch
+# Fixes "format not a string literal and no format arguments [-Werror=format-security]"
+# https://github.com/ddnet/ddnet/issues/9961
+Patch3:         0003-let-dbg_assert-format-the-string.patch
 
 BuildRequires:  desktop-file-utils
 BuildRequires:  libappstream-glib

                 reply	other threads:[~2026-09-03  0:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178839423260.1.14446605925976453985.rpms-ddnet-bb8defcee822@fedoraproject.org \
    --to=rafaelff@gnome.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox