public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
To: git-commits@fedoraproject.org
Subject: [rpms/vxl] f45: Fix linking issue on RISC-V
Date: Tue, 01 Sep 2026 11:10:46 GMT	[thread overview]
Message-ID: <178826104641.1.9545163796813687049.rpms-vxl-799260d8a1dc@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/vxl
Branch : f45
Commit : 799260d8a1dcfc502baa1f22e42672e4c46eca1d
Author : Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
Date   : 2026-09-01T09:58:05+02:00
Stats  : +40/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/vxl/c/799260d8a1dcfc502baa1f22e42672e4c46eca1d?branch=f45

Log:
Fix linking issue on RISC-V

---
diff --git a/0019-v3.5.0-fix-bbas_pro-missing-vpgl_camera-template.patch b/0019-v3.5.0-fix-bbas_pro-missing-vpgl_camera-template.patch
new file mode 100644
index 0000000..8842ca3
--- /dev/null
+++ b/0019-v3.5.0-fix-bbas_pro-missing-vpgl_camera-template.patch
@@ -0,0 +1,38 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Marcin Juszkiewicz <mjuszkiewicz@redhat.com>
+Date: Sun, 31 Aug 2026 00:00:00 +0000
+Subject: [PATCH 19/19] fix: add missing brdb_value_t<vpgl_camera_double_sptr>
+ instantiation to bbas_pro
+
+Several bbas_pro process files (bbas_camera_angles_process,
+bpgl_heightmap_from_disparity_process, bpgl_rectify_affine_image_pair_process)
+use vpgl_camera_double_sptr via brdb_value_t but the library lacks its own
+explicit template instantiation.
+
+On other architectures the symbols are pulled in implicitly through
+transitive link dependencies, but on RISC-V the stricter --as-needed
+linker behavior exposes the missing instantiation, causing undefined
+reference errors for brdb_value_t<vpgl_camera_double_sptr> methods
+(assign, eq, lt, b_read_value, b_write_value, get_type_string) when
+linking libbbas_pro.so consumers such as bbgm_pro_test_all.
+
+Assisted-by: Claude (Anthropic)
+---
+ .../Templates/brdb_value_t+vpgl_camera_double_sptr-.cxx | 5 +++++
+ 1 file changed, 5 insertions(+)
+ create mode 100644 contrib/brl/bpro/core/bbas_pro/Templates/brdb_value_t+vpgl_camera_double_sptr-.cxx
+
+diff --git a/contrib/brl/bpro/core/bbas_pro/Templates/brdb_value_t+vpgl_camera_double_sptr-.cxx b/contrib/brl/bpro/core/bbas_pro/Templates/brdb_value_t+vpgl_camera_double_sptr-.cxx
+new file mode 100644
+index 0000000000..6a44437000
+--- /dev/null
++++ b/contrib/brl/bpro/core/bbas_pro/Templates/brdb_value_t+vpgl_camera_double_sptr-.cxx
+@@ -0,0 +1,5 @@
++#include "vpgl/vpgl_camera_double_sptr.h"
++#include <vpgl/io/vpgl_io_camera.h>
++#include <brdb/brdb_value.hxx>
++
++BRDB_VALUE_INSTANTIATE(vpgl_camera_double_sptr, "vpgl_camera_double_sptr");
+--
+2.49.0
+

diff --git a/vxl.spec b/vxl.spec
index 2b71ec8..3c0bc59 100644
--- a/vxl.spec
+++ b/vxl.spec
@@ -57,6 +57,8 @@ Patch:     0016-v3.5.0-fix-linking.patch
 Patch:     0017-v3.5.0-remove-boxm2-processes-that-use-sdnet-that-re.patch
 # remove ctest dashboard config
 Patch:     0018-chore-remove-ctest-dashboard-config.patch
+# fix missing brdb_value_t<vpgl_camera_double_sptr> instantiation in bbas_pro (RISC-V linker)
+Patch:     0019-v3.5.0-fix-bbas_pro-missing-vpgl_camera-template.patch
 
 BuildRequires:  cmake
 BuildRequires:  Coin4-devel

                 reply	other threads:[~2026-09-01 11:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178826104641.1.9545163796813687049.rpms-vxl-799260d8a1dc@fedoraproject.org \
    --to=marcin@juszkiewicz.com.pl \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox