public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Milan Zamazal <mzamazal@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/libcamera] rawhide: Fix ov01a10 flickering
Date: Thu, 27 Aug 2026 18:08:08 GMT	[thread overview]
Message-ID: <178785408886.1.4578184853034984647.rpms-libcamera-99486641b80e@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/libcamera
            Branch : rawhide
            Commit : 99486641b80eea3c1460ded5cf852ef38ab03261
            Author : Milan Zamazal <mzamazal@redhat.com>
            Date   : 2026-08-27T20:04:12+02:00
            Stats  : +23/-1 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/libcamera/c/99486641b80eea3c1460ded5cf852ef38ab03261?branch=rawhide

            Log:
            Fix ov01a10 flickering

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=2483190.

The patch can be removed in the next upstream release since software ISP
exposure control has been reworked after 0.7.2.

---
diff --git a/0002-fix-ov01a10-flickering.patch b/0002-fix-ov01a10-flickering.patch
new file mode 100644
index 0000000..f3f8b7a
--- /dev/null
+++ b/0002-fix-ov01a10-flickering.patch
@@ -0,0 +1,18 @@
+diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp
+index 629e1a32d..95cc63a4a 100644
+--- a/src/ipa/simple/soft_simple.cpp
++++ b/src/ipa/simple/soft_simple.cpp
+@@ -228,10 +228,9 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)
+ 		context_.configuration.agc.againMin = camHelper_->gain(againMin);
+ 		context_.configuration.agc.againMax = camHelper_->gain(againMax);
+ 		context_.configuration.agc.again10 = std::max(context_.configuration.agc.againMin, 1.0);
+-		context_.configuration.agc.againMinStep =
+-			(context_.configuration.agc.againMax -
+-			 context_.configuration.agc.againMin) /
+-			100.0;
++		context_.configuration.agc.againMinStep = std::min(
++			std::abs(camHelper_->gain(againMin + 1) - camHelper_->gain(againMin)),
++			std::abs(camHelper_->gain(againMax) - camHelper_->gain(againMax - 1)));
+ 		if (camHelper_->blackLevel().has_value()) {
+ 			/*
+ 			 * The black level from camHelper_ is a 16 bit value, software ISP

diff --git a/libcamera.spec b/libcamera.spec
index 713ed59..29d1604 100644
--- a/libcamera.spec
+++ b/libcamera.spec
@@ -1,6 +1,6 @@
 Name:    libcamera
 Version: 0.7.2
-Release: 3%{?dist}
+Release: 4%{?dist}
 Summary: A library to support complex camera ISPs
 # see .reuse/dep5 and COPYING for details
 License: LGPL-2.1-or-later
@@ -12,6 +12,7 @@ Source2: qcam.metainfo.xml
 Source3: 70-libcamera.rules
 
 Patch01: 0001-disable-rpi-pisp.patch
+Patch02: 0002-fix-ov01a10-flickering.patch
 
 # libcamera does not currently build on these architectures
 ExcludeArch: s390x ppc64le
@@ -197,6 +198,9 @@ install -D -m 644 %SOURCE3 %{buildroot}/%{_udevrulesdir}/
 %{python3_sitearch}/*
 
 %changelog
+* Thu Aug 27 2026 Milan Zamazal <mzamazal@redhat.com> - 0.7.2-4
+- Fix ov01a10 flickering (rhbz#2483190)
+
 * Wed Jul 22 2026 Python Maint <python-maint@redhat.com> - 0.7.2-3
 - Rebuilt for Python 3.15.0b4 ABI change
 

                 reply	other threads:[~2026-08-27 18:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178785408886.1.4578184853034984647.rpms-libcamera-99486641b80e@fedoraproject.org \
    --to=mzamazal@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox