public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Joe Orton <jorton@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/neon] epel10: - fix NTLM test failures on bigendian systems
Date: Wed, 26 Aug 2026 14:40:13 GMT	[thread overview]
Message-ID: <178775521361.1.10028617389614612131.rpms-neon-0b290c37b080@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/neon
Branch : epel10
Commit : 0b290c37b08091003aef3c6b04f421c8d6ae5474
Author : Joe Orton <jorton@redhat.com>
Date   : 2026-03-13T13:10:52+00:00
Stats  : +45/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/neon/c/0b290c37b08091003aef3c6b04f421c8d6ae5474?branch=epel10

Log:
- fix NTLM test failures on bigendian systems

---
diff --git a/neon-0.37.0-bigend.patch b/neon-0.37.0-bigend.patch
new file mode 100644
index 0000000..ea99e8c
--- /dev/null
+++ b/neon-0.37.0-bigend.patch
@@ -0,0 +1,44 @@
+
+Fix test cases on bigendian systems.
+
+diff --git a/test/auth.c b/test/auth.c
+index 09fe2c6..41a0407 100644
+--- a/test/auth.c
++++ b/test/auth.c
+@@ -1788,10 +1788,10 @@ static int build_type2_challenge(tSmbNtlmAuthChallenge *challenge,
+             challenge->buffer[i*2] = domain[i];
+             challenge->buffer[i*2+1] = 0;
+         }
+-        challenge->uDomain.len = i * 2;
+-        challenge->uDomain.maxlen = i * 2;
+-        challenge->uDomain.offset = (unsigned char *)challenge->buffer - (unsigned char *)challenge;
+-        challenge->bufIndex = i * 2;
++        challenge->uDomain.len = htole16(i * 2);
++        challenge->uDomain.maxlen = htole16(i * 2);
++        challenge->uDomain.offset = htole32((unsigned char *)challenge->buffer - (unsigned char *)challenge);
++        challenge->bufIndex = htole32(i * 2);
+     }
+ 
+     return OK;
+@@ -1846,8 +1846,8 @@ static int serve_ntlm(ne_socket *sock, void *userdata)
+ 
+         ONV(memcmp(request.ident, "NTLMSSP\0", 8) != 0,
+             ("Type 1 message has invalid NTLMSSP signature"));
+-        ONV(request.msgType != 1,
+-            ("Type 1 message has wrong type: %u (expected 1)", request.msgType));
++        ONV(le32toh(request.msgType) != 1,
++            ("Type 1 message has wrong type: %u (expected 1)", le32toh(request.msgType)));
+ 
+         NE_DEBUG(NE_DBG_HTTP, "auth: Valid Type 1 message received.\n");
+ #ifdef NE_DEBUGGING
+@@ -1893,8 +1893,8 @@ static int serve_ntlm(ne_socket *sock, void *userdata)
+ 
+     ONV(memcmp(response.ident, "NTLMSSP\0", 8) != 0,
+         ("Type 3 message has invalid NTLMSSP signature"));
+-    ONV(response.msgType != 3,
+-        ("Type 3 message has wrong type: %u (expected 3)", response.msgType));
++    ONV(le32toh(response.msgType) != 3,
++        ("Type 3 message has wrong type: %u (expected 3)", le32toh(response.msgType)));
+     
+     /* Validate security buffers have reasonable values */
+     ONV(response.lmResponse.len > 24 && response.lmResponse.len != 24,

diff --git a/neon.spec b/neon.spec
index a71490f..4102480 100644
--- a/neon.spec
+++ b/neon.spec
@@ -13,6 +13,7 @@ License: LGPL-2.0-or-later
 URL: https://notroj.github.io/neon/
 Source0: https://notroj.github.io/neon/neon-%{version}.tar.gz
 Patch0: neon-0.34.0-multilib.patch
+Patch1: neon-0.37.0-bigend.patch
 BuildRequires: expat-devel, openssl-devel, zlib-devel, krb5-devel
 BuildRequires: pkgconfig, make, gcc, xmlto, libntlm-devel
 %if %{with pkcs11}

                 reply	other threads:[~2026-08-26 14:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178775521361.1.10028617389614612131.rpms-neon-0b290c37b080@fedoraproject.org \
    --to=jorton@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox