public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Tom Rix <Tom.Rix@amd.com>
To: git-commits@fedoraproject.org
Subject: [rpms/rocm-compilersupport] rawhide: Enable libcxx
Date: Tue, 25 Aug 2026 13:31:19 GMT [thread overview]
Message-ID: <178766467956.1.14429200176057320819.rpms-rocm-compilersupport-394cc0853a80@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/rocm-compilersupport
Branch : rawhide
Commit : 394cc0853a801e76ea9daef9d5e6460c020a4893
Author : Tom Rix <Tom.Rix@amd.com>
Date : 2026-08-25T06:30:45-07:00
Stats : +42/-3 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/rocm-compilersupport/c/394cc0853a801e76ea9daef9d5e6460c020a4893?branch=rawhide
Log:
Enable libcxx
Signed-off-by: Tom Rix <Tom.Rix@amd.com>
---
diff --git a/0001-libcxx-noinline-workaround.patch b/0001-libcxx-noinline-workaround.patch
new file mode 100644
index 0000000..7c06f1c
--- /dev/null
+++ b/0001-libcxx-noinline-workaround.patch
@@ -0,0 +1,35 @@
+From 8aed398c773be07b6a947fad553b931ef9582041 Mon Sep 17 00:00:00 2001
+From: Tom Rix <Tom.Rix@amd.com>
+Date: Mon, 24 Aug 2026 17:48:10 -0700
+Subject: [PATCH] libcxx noinline workaround
+
+---
+ libcxx/include/__configuration/attributes.h | 12 ++++++++++++
+ 1 file changed, 12 insertions(+)
+
+diff --git a/libcxx/include/__configuration/attributes.h b/libcxx/include/__configuration/attributes.h
+index 39683b7688d7..099329145eac 100644
+--- a/libcxx/include/__configuration/attributes.h
++++ b/libcxx/include/__configuration/attributes.h
+@@ -386,6 +386,18 @@
+ //
+ // See https://github.com/llvm/llvm-project/pull/73838 for more details.
+ # define _LIBCPP_NOINLINE __attribute__((noinline))
++#elif __has_attribute(noinline)
++// when not in host mode (not hip) the rocm runtime hip/amd_detail/host_defines
++// has this define
++// #define __noinline__
++// Which causes this error
++// /usr/lib64/rocm/llvm/bin/../include/c++/v1/__configuration/attributes.h:389:35: error:
++// too few arguments provided to function-like macro invocation
++// 389 | #elif __has_attribute(__noinline__)
++// | ^
++//
++// so add another flavor using noinline over __noinline__
++# define _LIBCPP_NOINLINE __attribute__((noinline))
+ #elif __has_attribute(__noinline__)
+ # define _LIBCPP_NOINLINE __attribute__((__noinline__))
+ #else
+--
+2.55.0
+
diff --git a/rocm-compilersupport.spec b/rocm-compilersupport.spec
index 69822bc..0293359 100644
--- a/rocm-compilersupport.spec
+++ b/rocm-compilersupport.spec
@@ -123,7 +123,7 @@
%global build_gold OFF
%endif
-%bcond_with libcxx
+%bcond_without libcxx
%if %{with libcxx}
%global build_libcxx ON
%else
@@ -135,7 +135,7 @@ Version: %{llvm_maj_ver}
%if %{with preview}
Release: 1000.rocm%{rocm_version}%{?dist}
%else
-Release: 1.rocm%{rocm_version}%{?dist}
+Release: 2.rocm%{rocm_version}%{?dist}
%endif
Summary: Various AMD ROCm LLVM related services
@@ -175,6 +175,7 @@ Patch5: 0001-lld-workaround-.gnu.version-change.patch
# When clang bungles the rocm install path, it gets the linking of libamdhip64 wrong
# Convert from an absolute path <path-to>/libamdhip64.so to using -lamdhip64
Patch6: 0001-clang-23-link-libamdhip64.patch
+Patch7: 0001-libcxx-noinline-workaround.patch
BuildRequires: cmake
%if 0%{?fedora} || 0%{?suse_version}
@@ -1151,7 +1152,10 @@ rm %{buildroot}%{bundle_prefix}/lib/libear/ear.c
%{bundle_prefix}/lib/libomp*.so
%changelog
-* Fri Aug 7 2026 Tom Rix <Tom.Rix@amd.com> - 23-1.rocm7.14.1
+* Wed Aug 25 2025 Tom Rix <Tom.Rix@amd.com> - 23-2.rocm7.14.0
+- Enable libcxx
+
+* Fri Aug 7 2026 Tom Rix <Tom.Rix@amd.com> - 23-1.rocm7.14.0
- Update to 7.14
* Thu Jul 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 22-13.rocm7.2.1
reply other threads:[~2026-08-25 13:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178766467956.1.14429200176057320819.rpms-rocm-compilersupport-394cc0853a80@fedoraproject.org \
--to=tom.rix@amd.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox