public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michael Catanzaro <mcatanzaro@gnome.org>
To: git-commits@fedoraproject.org
Subject: [rpms/gnome-keyring] f45: Add patch for crash on passphrase prompt
Date: Mon, 24 Aug 2026 15:55:45 GMT	[thread overview]
Message-ID: <178758694537.1.4989813536127333376.rpms-gnome-keyring-b7ebb6723044@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/gnome-keyring
Branch : f45
Commit : b7ebb6723044bb4d714e25fe1bbeacd5eb43eda1
Author : Michael Catanzaro <mcatanzaro@gnome.org>
Date   : 2026-08-24T10:54:53-05:00
Stats  : +40/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/gnome-keyring/c/b7ebb6723044bb4d714e25fe1bbeacd5eb43eda1?branch=f45

Log:
Add patch for crash on passphrase prompt

---
diff --git a/gnome-keyring.spec b/gnome-keyring.spec
index abc9e32..842edd7 100644
--- a/gnome-keyring.spec
+++ b/gnome-keyring.spec
@@ -23,6 +23,8 @@ Source0:        https://download.gnome.org/sources/%{name}/%{gnome_major_version
 # Ensure the login collection is registered after unlocking
 Patch:          78.patch
 
+Patch:          prompt-crash.patch
+
 BuildRequires:  pkgconfig(gcr-3) >= %{gcr_version}
 BuildRequires:  pkgconfig(glib-2.0) >= %{glib2_version}
 BuildRequires:  pkgconfig(libcap-ng)

diff --git a/prompt-crash.patch b/prompt-crash.patch
new file mode 100644
index 0000000..9b9c0c0
--- /dev/null
+++ b/prompt-crash.patch
@@ -0,0 +1,38 @@
+From ff18dbaa05358bc615795c868c147c621aa6d8ac Mon Sep 17 00:00:00 2001
+From: Michael Catanzaro <mcatanzaro@gnome.org>
+Date: Mon, 24 Aug 2026 10:41:46 -0500
+Subject: [PATCH] secret-unlock: fix crash when prompt is dismissed
+
+Each time we process a new prompt from the queue, we assert to ensure
+that we are not already processing a current prompt. Good idea, but the
+state tracking is messed up.
+---
+ daemon/dbus/gkd-secret-unlock.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/daemon/dbus/gkd-secret-unlock.c b/daemon/dbus/gkd-secret-unlock.c
+index a1a551f6..8681a117 100644
+--- a/daemon/dbus/gkd-secret-unlock.c
++++ b/daemon/dbus/gkd-secret-unlock.c
+@@ -155,6 +155,9 @@ mark_as_complete (GkdSecretUnlock *self, gboolean dismissed)
+ 		return FALSE;
+ 	self->completed = TRUE;
+ 
++	g_free (self->current);
++	self->current = NULL;
++
+ 	g_variant_builder_init (&builder, G_VARIANT_TYPE ("ao"));
+ 	for (i = 0; i < self->results->len; ++i) {
+ 		value = g_array_index (self->results, gchar*, i);
+@@ -208,8 +211,6 @@ on_unlock_complete (GObject *object, GAsyncResult *res, gpointer user_data)
+ 
+ 	/* The user cancelled the protected auth prompt */
+ 	} else if (g_error_matches (error, GCK_ERROR, CKR_PIN_INCORRECT)) {
+-		g_free (self->current);
+-		self->current = NULL;
+ 		mark_as_complete (self, TRUE);
+ 
+ 	/* The operation was cancelled via Dismiss call */
+-- 
+2.55.0
+

                 reply	other threads:[~2026-08-24 15:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178758694537.1.4989813536127333376.rpms-gnome-keyring-b7ebb6723044@fedoraproject.org \
    --to=mcatanzaro@gnome.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox