public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Dominik 'Rathann' Mierzejewski <dominik@greysector.net>
To: git-commits@fedoraproject.org
Subject: [rpms/tin] epel10: fix segfault when clicking past the end of topic list in xterm (#1921096)
Date: Sun, 23 Aug 2026 23:18:12 GMT	[thread overview]
Message-ID: <178752709233.1.10684614152351966932.rpms-tin-70f250f074a4@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/tin
Branch : epel10
Commit : 70f250f074a4baf55c4bbb3183ea034d66d905de
Author : Dominik 'Rathann' Mierzejewski <dominik@greysector.net>
Date   : 2021-02-01T11:46:14+01:00
Stats  : +18/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/tin/c/70f250f074a4baf55c4bbb3183ea034d66d905de?branch=epel10

Log:
fix segfault when clicking past the end of topic list in xterm (#1921096)

---
diff --git a/tin-2.4.5-segfault.patch b/tin-2.4.5-segfault.patch
new file mode 100644
index 0000000..3334524
--- /dev/null
+++ b/tin-2.4.5-segfault.patch
@@ -0,0 +1,12 @@
+diff -up tin-2.4.5/src/global.c.orig tin-2.4.5/src/global.c
+--- tin-2.4.5/src/global.c.orig	2020-12-01 11:51:01.000000000 +0100
++++ tin-2.4.5/src/global.c	2021-02-01 11:43:34.940564498 +0100
+@@ -331,7 +331,7 @@ global_mouse_action(
+ 				return GLOBAL_PAGE_DOWN;
+ 
+ 			erase_arrow();
+-			currmenu->curr = xrow - INDEX_TOP + currmenu->first;
++			currmenu->curr = MIN(xrow - INDEX_TOP + currmenu->first, currmenu->max - INDEX_TOP + 1);
+ 			currmenu->draw_arrow();
+ 
+ 			if (xmouse == MOUSE_BUTTON_1)

diff --git a/tin.spec b/tin.spec
index ac453e4..22fc0c8 100644
--- a/tin.spec
+++ b/tin.spec
@@ -1,12 +1,13 @@
 Name: tin
 Version: 2.4.5
-Release: 2%{?dist}
+Release: 3%{?dist}
 Summary: Basic Internet news reader
 License: BSD
 URL: http://www.tin.org/
 Source0: ftp://ftp.tin.org/pub/news/clients/tin/stable/tin-%{version}.tar.xz
 Source1: ftp://ftp.tin.org/pub/news/clients/tin/stable/tin-%{version}.tar.xz.sign
 Source2: tin-pgp-key-0x5A49550EB490B4D1.txt
+Patch0: tin-2.4.5-segfault.patch
 BuildRequires: make
 BuildRequires: %{_bindir}/ispell
 BuildRequires:  gcc-c++
@@ -32,6 +33,7 @@ gpg1 --homedir=${workdir} --pgp2 --yes --output="${workring}" --dearmor %{S:2}
 gpg1 --homedir=${workdir} --pgp2 --verify --keyring="${workring}" %{S:1} %{S:0}
 rm -r ${workdir}
 %setup -q
+%patch0 -p1
 
 %build
 %configure \
@@ -76,6 +78,9 @@ rm -r ${workdir}
 %{_mandir}/man5/*
 
 %changelog
+* Mon Feb 01 2021 Dominik Mierzejewski <rpm@greysector.net> - 2.4.5-3
+- fix segfault when clicking past the end of topic list in xterm (#1921096)
+
 * Wed Jan 27 2021 Fedora Release Engineering <releng@fedoraproject.org> - 2.4.5-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
 

                 reply	other threads:[~2026-08-23 23:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178752709233.1.10684614152351966932.rpms-tin-70f250f074a4@fedoraproject.org \
    --to=dominik@greysector.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox