public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/arbor] f45: fix: add patch to use system fmt
Date: Wed, 19 Aug 2026 15:05:08 GMT	[thread overview]
Message-ID: <178715190801.1.14417670550384076557.rpms-arbor-dc723081dd02@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/arbor
            Branch : f45
            Commit : dc723081dd02d83c29521e496f84c834c22eee68
            Author : Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@gmail.com>
            Date   : 2026-08-19T12:13:31+01:00
            Stats  : +36/-0 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/arbor/c/dc723081dd02d83c29521e496f84c834c22eee68?branch=f45

            Log:
            fix: add patch to use system fmt

- Fixes rhbz#2433869

Assisted-by: opencode (DeepSeek V4 Flash)

---
diff --git a/0005-Use-system-fmt.patch b/0005-Use-system-fmt.patch
new file mode 100644
index 0000000..95a2cb7
--- /dev/null
+++ b/0005-Use-system-fmt.patch
@@ -0,0 +1,33 @@
+From 670389c2148c4975e82118c01f2bee6cbc2e3e40 Mon Sep 17 00:00:00 2001
+From: "Ankur Sinha (Ankur Sinha Gmail)" <sanjay.ankur@gmail.com>
+Date: Wed, 19 Aug 2026 10:38:31 +0100
+Subject: [PATCH] Use system fmt instead of CPM download
+
+find_package(fmt 12.1.0) fails on Fedora 44, where the system fmt is
+version 11.x, so CPM tries to download fmt 12.1.0 from GitHub at
+configure time, which fails in the offline buildroot. Use the system
+fmt without a version requirement instead; the fmt::fmt-header-only
+target used by arbor is provided by fmt-devel.
+---
+ CMakeLists.txt | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index cef4f4a2..72ef717f 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -345,10 +345,7 @@ else()
+ endif()
+ install(TARGETS ext-pugixml EXPORT arbor-targets)
+ 
+-CPMFindPackage(NAME fmt
+-              GITHUB_REPOSITORY fmtlib/fmt
+-              VERSION 12.1.0
+-              GIT_TAG 12.1.0)
++find_package(fmt REQUIRED)
+ 
+ add_library(ext-gtest INTERFACE)
+ add_library(ext-bench INTERFACE)
+-- 
+2.55.0
+

diff --git a/arbor.spec b/arbor.spec
index acd961c..a1af269 100644
--- a/arbor.spec
+++ b/arbor.spec
@@ -68,6 +68,9 @@ Patch:          0002-Use-system-Random123.patch
 Patch:          0003-Use-system-GTest.patch
 # Add missing standard includes for GCC 16
 Patch:          0004-Add-missing-standard-includes-to-profiler.patch
+# Use system fmt instead of letting CPM download it (it tries to fetch
+# fmt 12.1.0, which is newer than the fmt 11 in Fedora 44)
+Patch:          0005-Use-system-fmt.patch
 
 # Random123 does not support:
 #   mips64r2 mips32r2 s390

                 reply	other threads:[~2026-08-19 15:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178715190801.1.14417670550384076557.rpms-arbor-dc723081dd02@fedoraproject.org \
    --to=sanjay.ankur@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox