public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Tomas Bzatek <tbzatek@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/nvme-cli] f44: * Tue Aug 18 2026 Tomas Bzatek <tbzatek@redhat.com> - 2.16-3
Date: Tue, 18 Aug 2026 10:46:58 GMT	[thread overview]
Message-ID: <178705001835.1.6215647058105452063.rpms-nvme-cli-405e916ca20f@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/nvme-cli
            Branch : f44
            Commit : 405e916ca20fb56d7a797357e1bb9821118bfb2b
            Author : Tomas Bzatek <tbzatek@redhat.com>
            Date   : 2026-08-18T12:46:35+02:00
            Stats  : +35/-1 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/nvme-cli/c/405e916ca20fb56d7a797357e1bb9821118bfb2b?branch=f44

            Log:
            * Tue Aug 18 2026 Tomas Bzatek <tbzatek@redhat.com> - 2.16-3
- Fix ignored interruption in format command (#2501829)

---
diff --git a/format-sigint.patch b/format-sigint.patch
new file mode 100644
index 0000000..cd65805
--- /dev/null
+++ b/format-sigint.patch
@@ -0,0 +1,28 @@
+From cb5a61895e7327827158ad32fc07e10722d8777e Mon Sep 17 00:00:00 2001
+From: g0l4 <g0l4@g0l4.top>
+Date: Wed, 24 Jun 2026 11:48:55 +0800
+Subject: [PATCH] nvme: fix ignored interruption in format command
+
+Add nvme_sigint_received wrapper around sleep, so it will exit instead
+of continue when a SIGINT is received.
+
+Signed-off-by: g0l4 <g0l4@g0l4.top>
+---
+ nvme.c | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/nvme.c b/nvme.c
+index cec40249fd..289f5257e3 100644
+--- a/nvme.c
++++ b/nvme.c
+@@ -7007,7 +7007,10 @@ static int format_cmd(int argc, char **argv, struct command *acmd, struct plugin
+ 			"WARNING: Format may irrevocably delete this device's data.\n"
+ 			"You have 10 seconds to press Ctrl-C to cancel this operation.\n\n"
+ 			"Use the force [--force] option to suppress this warning.\n");
++		nvme_sigint_received = false;
+ 		sleep(10);
++		if (nvme_sigint_received)
++			return -EINTR;
+ 		fprintf(stderr, "Sending format operation ...\n");
+ 	}
+ 

diff --git a/nvme-cli.spec b/nvme-cli.spec
index 09c1288..fc4433d 100644
--- a/nvme-cli.spec
+++ b/nvme-cli.spec
@@ -5,7 +5,7 @@
 
 Name:           nvme-cli
 Version:        2.16
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        NVMe management command line interface
 
 License:        GPL-2.0-only
@@ -14,6 +14,9 @@ Source0:        %{url}/archive/v%{version_no_tilde}/%{name}-%{version_no_tilde}.
 Source1:        99-nvme-nbft-connect.sh
 Source2:        99-nvme-nbft-no-ignore-carrier.conf
 
+# https://bugzilla.redhat.com/show_bug.cgi?id=2501829
+Patch0:         format-sigint.patch
+
 BuildRequires:  meson >= 0.53
 BuildRequires:  gcc gcc-c++
 BuildRequires:  systemd-devel
@@ -119,6 +122,9 @@ fi
 
 
 %changelog
+* Tue Aug 18 2026 Tomas Bzatek <tbzatek@redhat.com> - 2.16-3
+- Fix ignored interruption in format command (#2501829)
+
 * Fri Jan 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 2.16-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
 

                 reply	other threads:[~2026-08-18 10:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178705001835.1.6215647058105452063.rpms-nvme-cli-405e916ca20f@fedoraproject.org \
    --to=tbzatek@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox