public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Akira TAGOH <akira@tagoh.org>
To: git-commits@fedoraproject.org
Subject: [tests/fonts] rhel9: validate_family: update to use common functions
Date: Thu, 13 Aug 2026 10:29:33 GMT	[thread overview]
Message-ID: <178661697356.1.4496587912679061030.tests-fonts-5b790ba2c1e6@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : tests/fonts
Branch : rhel9
Commit : 5b790ba2c1e6b50518153315bd5fee9e86d84392
Author : Akira TAGOH <akira@tagoh.org>
Date   : 2025-11-25T12:19:54+09:00
Stats  : +9/-13 in 1 file(s)
URL    : https://src.fedoraproject.org/tests/fonts/c/5b790ba2c1e6b50518153315bd5fee9e86d84392?branch=rhel9

Log:
validate_family: update to use common functions

---
diff --git a/tests/validate_family/test.sh b/tests/validate_family/test.sh
index 9eb8a3b..155406f 100755
--- a/tests/validate_family/test.sh
+++ b/tests/validate_family/test.sh
@@ -3,6 +3,7 @@
 # vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
 
 . /usr/share/beakerlib/beakerlib.sh || exit 1
+. ../functions
 
 PACKAGE=${PACKAGE:-"blahblah-fonts"}
 FONT_FAMILY=${FONT_FAMILY:-"family anme"}
@@ -38,10 +39,11 @@ function test_pkg {
 }
 
 function test_validate_family {
-    local pkg=${1:-"unknown package"}
-    local fcfamily=${2:-"unknown family"}
-    local fcexpat=${3:-}
-    local indexes=${4:-}
+    local elems=("$@")
+    local pkg=${elems[0]:-"unknown package"}
+    local fcfamily=${elems[1]:-"unknown family"}
+    local fcexpat=${elems[2]:-}
+    local indexes=${elems[3]:-}
 
     test_pkg "$pkg"
 
@@ -92,17 +94,11 @@ rlJournalStart
     if [ -n "$VARLIST" ] && [ ! -f "$TMT_TREE/plans/$VARLIST" ]; then
         rlLogWarning "No $VARLIST in VARLIST envvar at \$TMT_TREE/plans"
     fi
+    args=("PACKAGE" "FONT_FAMILY" "FONT_VALIDATE_EXCLUDE_FILES" "FONT_VALIDATE_INDEXES")
     if [ -n "$VARLIST" ] && [ -f "$TMT_TREE/plans/$VARLIST" ]; then
-        rlLogInfo "Reading variables from $VARLIST"
-        grep -E -v "^#" "$TMT_TREE/plans/$VARLIST" | while IFS=";" read -r _PACKAGE FONT_ALIAS FONT_LANG FONT_WIDTH _FONT_FAMILY SANS SERIF MONO EMOJI MATH FONT_LANG_EXCLUDE_FILES _FONT_VALIDATE_EXCLUDE_FILES _FONT_CONF_EXCLUDE_FILES _FONT_VALIDATE_INDEXES FONT_LANG_INDEXES dummy; do
-            rlLogInfo "  PACKAGE: $_PACKAGE"
-            rlLogInfo "  FONT_FAMILY: $_FONT_FAMILY"
-            rlLogInfo "  FONT_VALIDATE_EXCLUDE_FILES: $_FONT_VALIDATE_EXCLUDE_FILES"
-            rlLogInfo "  FONT_VALIDATE_INDEXES: $_FONT_VALIDATE_INDEXES"
-            test_validate_family "$_PACKAGE" "$_FONT_FAMILY" "$_FONT_VALIDATE_EXCLUDE_FILES" "$_FONT_VALIDATE_INDEXES"
-        done
+        read_varlist "$TMT_TREE/plans/$VARLIST" "test_validate_family" "${args[@]}"
     else
-        test_validate_family "$PACKAGE" "$FONT_FAMILY" "$FONT_VALIDATE_EXCLUDE_FILES" "$FONT_VALIDATE_INDEXES"
+        call_test "test_validate_family" "${args[@]}"
     fi
 
     rlPhaseStartCleanup

                 reply	other threads:[~2026-08-13 10:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178661697356.1.4496587912679061030.tests-fonts-5b790ba2c1e6@fedoraproject.org \
    --to=akira@tagoh.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox