public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michael Catanzaro <mcatanzaro@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/glib2] cve-2026-58016-f44: Revert "Run tests in %check"
Date: Tue, 11 Aug 2026 10:38:12 GMT	[thread overview]
Message-ID: <178644469296.1.1201240861553325530.rpms-glib2-3aabc6f82093@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/glib2
            Branch : cve-2026-58016-f44
            Commit : 3aabc6f8209303c829de92729a37ae42b8187c56
            Author : Michael Catanzaro <mcatanzaro@redhat.com>
            Date   : 2024-04-30T14:30:33-05:00
            Stats  : +2/-8 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/glib2/c/3aabc6f8209303c829de92729a37ae42b8187c56?branch=cve-2026-58016-f44

            Log:
            Revert "Run tests in %check"

This reverts commit 13ce7f6d350feb011b7aa7af455036e719e2f4f1.

This causes the build to fail. Apparently I failed to notice that even
though the tests were passing, the build itself does not. The problem is
that running the tests increases the number of files that get installed:

RPM build errors:
error: Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/bin/gio-querymodules-2.80.0-4.fc41.x86_64.debug
    Duplicate build-ids /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/libexec/installed-tests/glib/642026 and /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/libexec/installed-tests/glib/642026-ec
    Duplicate build-ids /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/libexec/installed-tests/glib/cxx-98 and /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/libexec/installed-tests/glib/cxx-03
    Duplicate build-ids /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/lib/debug/usr/libexec/installed-tests/glib/642026-2.80.0-4.fc41.x86_64.debug and /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/lib/debug/usr/libexec/installed-tests/glib/642026-ec-2.80.0-4.fc41.x86_64.debug
    Duplicate build-ids /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/lib/debug/usr/libexec/installed-tests/glib/cxx-03-2.80.0-4.fc41.x86_64.debug and /builddir/build/BUILDROOT/glib2-2.80.0-4.fc41.x86_64/usr/lib/debug/usr/libexec/installed-tests/glib/cxx-98-2.80.0-4.fc41.x86_64.debug
    Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/bin/gio-querymodules-2.80.0-4.fc41.x86_64.debug

This doesn't make sense and requires further investigation.

---
diff --git a/glib2.spec b/glib2.spec
index 1cd5cb0..72d812d 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -20,10 +20,12 @@ BuildRequires:  gcc
 BuildRequires:  gcc-c++
 BuildRequires:  gettext
 BuildRequires:  perl-interpreter
+# for sys/inotify.h
 BuildRequires:  glibc-devel
 BuildRequires:  libattr-devel
 BuildRequires:  libselinux-devel
 BuildRequires:  meson
+# for sys/sdt.h
 BuildRequires:  systemtap-sdt-devel
 BuildRequires:  pkgconfig(gi-docgen)
 BuildRequires:  pkgconfig(libelf)
@@ -37,11 +39,6 @@ BuildRequires:  /usr/bin/g-ir-scanner
 BuildRequires:  /usr/bin/marshalparser
 BuildRequires:  /usr/bin/rst2man
 
-# Dependencies for tests
-BuildRequires:  shared-mime-info
-BuildRequires:  /usr/bin/dbus-daemon
-BuildRequires:  /usr/bin/update-desktop-database
-
 # For gnutls-hmac.patch. We now dlopen libgnutls.so.30 so that we can build a
 # static glib2 without depending on a static build of GnuTLS as well. This will
 # ensure we notice if the GnuTLS soname bumps, so that we can update our patch.
@@ -122,9 +119,6 @@ the functionality of the installed glib2 package.
 %install
 %meson_install
 
-%check
-%meson_test
-
 # We need reproducible .pyc files across architectures to support multilib installations
 # https://bugzilla.redhat.com/show_bug.cgi?id=2008912
 # https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Appendix/#_byte_compilation_reproducibility

                 reply	other threads:[~2026-08-11 10:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178644469296.1.1201240861553325530.rpms-glib2-3aabc6f82093@fedoraproject.org \
    --to=mcatanzaro@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox