public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Alexander Larsson <alexl@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/glib2] cve-2026-58016-f44: - Don't return generic fallback icons for files, as this means custom
Date: Tue, 11 Aug 2026 10:33:55 GMT	[thread overview]
Message-ID: <178644443518.1.4732852107481296655.rpms-glib2-6e8ec0de6680@fedoraproject.org> (raw)

        A new commit has been pushed.

        Repo   : rpms/glib2
        Branch : cve-2026-58016-f44
        Commit : 6e8ec0de66805208265b2937844b25e3f612b9b1
        Author : Alexander Larsson <alexl@fedoraproject.org>
        Date   : 2008-10-24T08:41:50+00:00
        Stats  : +27/-1 in 2 file(s)
        URL    : https://src.fedoraproject.org/rpms/glib2/c/6e8ec0de66805208265b2937844b25e3f612b9b1?branch=cve-2026-58016-f44

        Log:
        - Don't return generic fallback icons for files, as this means custom
mimetypes don't work (from svn)

---
diff --git a/glib-2.18.2-no-generic-icons.patch b/glib-2.18.2-no-generic-icons.patch
new file mode 100644
index 0000000..9308297
--- /dev/null
+++ b/glib-2.18.2-no-generic-icons.patch
@@ -0,0 +1,19 @@
+Index: gio/glocalfileinfo.c
+===================================================================
+--- gio/glocalfileinfo.c	(revision 7620)
++++ gio/glocalfileinfo.c	(revision 7621)
+@@ -1577,12 +1577,8 @@ _g_local_file_info_get (const char      
+ 
+                       if (S_ISDIR (statbuf.st_mode)) 
+                         type_icon = "folder";
+-                      else if (statbuf.st_mode & S_IXUSR)
+-                        type_icon = "application-x-executable";
+-                      else
+-                        type_icon = "text-x-generic";
+-
+-                      g_themed_icon_append_name (G_THEMED_ICON (icon), type_icon);
++                      if (type_icon)
++                        g_themed_icon_append_name (G_THEMED_ICON (icon), type_icon);
+                     }
+                 }
+ 

diff --git a/glib2.spec b/glib2.spec
index 0ac4a46..ed0587b 100644
--- a/glib2.spec
+++ b/glib2.spec
@@ -3,7 +3,7 @@
 Summary: A library of handy utility functions
 Name: glib2
 Version: 2.18.2
-Release: 1%{?dist}
+Release: 2%{?dist}
 License: LGPLv2+
 Group: System Environment/Libraries
 URL: http://www.gtk.org
@@ -22,6 +22,8 @@ BuildRequires: glibc-devel
 # https://bugzilla.redhat.com/show_bug.cgi?id=442835
 # http://bugzilla.gnome.org/show_bug.cgi?id=528670
 Patch2: gio-2.18-always-pass-fuse-file-uri.patch
+# http://bugzilla.gnome.org/show_bug.cgi?id=528320 (from svn)
+Patch3: glib-2.18.2-no-generic-icons.patch
 
 # this patch requires autoreconf
 BuildRequires: autoconf automake libtool gettext-devel gtk-doc
@@ -58,6 +60,7 @@ of version 2 of the GLib library.
 %prep
 %setup -q -n glib-%{version}
 %patch2 -p1 -b .always-pass-fuse-file-uri
+%patch3 -p0 -b .no-generic-icons
 
 autoreconf
 
@@ -134,6 +137,10 @@ rm -rf $RPM_BUILD_ROOT
 %{_libdir}/lib*.a
 
 %changelog
+* Fri Oct 24 2008 Alexander Larsson <alexl@redhat.com> - 2.18.2-2
+- Don't return generic fallback icons for files,
+  as this means custom mimetypes don't work (from svn)
+
 * Thu Oct 16 2008 Matthias Clasen <mclasen@redhat.com> - 2.18.2-1
 - Update to 2.18.2
 

                 reply	other threads:[~2026-08-11 10:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178644443518.1.4732852107481296655.rpms-glib2-6e8ec0de6680@fedoraproject.org \
    --to=alexl@fedoraproject.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox