public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Sandro <devel@penguinpee.nl>
To: git-commits@fedoraproject.org
Subject: [rpms/fedpkg] 1.48-1: Fix bash auto completion
Date: Mon, 10 Aug 2026 21:46:19 GMT	[thread overview]
Message-ID: <178639837916.1.3867692348916701171.rpms-fedpkg-78c34cd71e25@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/fedpkg
            Branch : 1.48-1
            Commit : 78c34cd71e25f19cbd1d0cc52e7d55a68a06880b
            Author : Sandro <devel@penguinpee.nl>
            Date   : 2025-12-01T16:37:24+00:00
            Stats  : +16/-7 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/fedpkg/c/78c34cd71e25f19cbd1d0cc52e7d55a68a06880b?branch=1.48-1

            Log:
            Fix bash auto completion

Fixes: rhbz#2391023

---
diff --git a/fedpkg.spec b/fedpkg.spec
index 5e7d753..6297589 100644
--- a/fedpkg.spec
+++ b/fedpkg.spec
@@ -1,5 +1,3 @@
-%define bash_completion_dir %{_datadir}/bash-completion/completions
-
 # hatchling is not supported in Python 3.6 releases (epel8)
 %if 0%{?rhel} == 8
 %global with_hatchling 0
@@ -9,7 +7,7 @@
 
 Name:           fedpkg
 Version:        1.47
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Fedora utility for working with dist-git
 
 # Automatically converted from old format: GPLv2+ - review is highly recommended.
@@ -92,6 +90,11 @@ via the python-argcomplete framework.
 %py_build
 %endif
 %{python3} doc/fedpkg_man_page.py > fedpkg.1
+register-python-argcomplete --shell bash fedpkg > fedpkg.bash
+%if 0%{?with_hatchling}
+# argcomplete version in EPEL8 does not have support for fish
+register-python-argcomplete --shell fish fedpkg > fedpkg.fish
+%endif
 
 %install
 %if 0%{?with_hatchling}
@@ -102,10 +105,9 @@ via the python-argcomplete framework.
 %endif
 %{__install} -d %{buildroot}%{_mandir}/man1
 %{__install} -p -m 0644 fedpkg.1 %{buildroot}%{_mandir}/man1
-echo "register-python-argcomplete fedpkg" > fedpkg.bash
-%{__install} -d %{buildroot}%{bash_completion_dir}
-%{__install} -p -m 0644 fedpkg.bash %{buildroot}%{bash_completion_dir}
+%{__install} -D -p -m 0644 fedpkg.bash -t %{buildroot}%{bash_completions_dir}
 %if 0%{?with_hatchling}
+%{__install} -D -p -m 0644 fedpkg.fish -t %{buildroot}%{fish_completions_dir}
 # config file /etc/rpkg/fedpkg.conf is extracted to %{buildroot}/usr/etc/... by pyproject_install
 %{__install} -d %{buildroot}%{_sysconfdir}
 mv %{buildroot}/usr/etc/* %{buildroot}%{_sysconfdir}
@@ -137,10 +139,17 @@ mv %{buildroot}/usr/etc/* %{buildroot}%{_sysconfdir}
 %config(noreplace) %{_sysconfdir}/rpkg/fedpkg-stage.conf
 
 %files -n fedpkg-completion
-%config(noreplace) %{bash_completion_dir}/fedpkg.bash
+%config(noreplace) %{bash_completions_dir}/fedpkg.bash
+%if 0%{?with_hatchling}
+%config(noreplace) %{fish_completions_dir}/fedpkg.fish
+%endif
 
 
 %changelog
+* Mon Dec 01 2025 Sandro <devel@penguinpee.nl> - 1.47-2
+- Fix bash auto completion
+- Add fish auto completion
+
 * Wed Nov 26 2025 Ondřej Nosek <onosek@redhat.com> - 1.47-1
 - Use ruff code checker instead of bandit (onosek)
 - Clone the API key info into all help messages (mpospisi)

                 reply	other threads:[~2026-08-10 21:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178639837916.1.3867692348916701171.rpms-fedpkg-78c34cd71e25@fedoraproject.org \
    --to=devel@penguinpee.nl \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox