public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Chenxiong Qi <cqi@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/fedpkg] 1.48-1: Fix broken syntax in bash completion
Date: Mon, 10 Aug 2026 21:45:33 GMT [thread overview]
Message-ID: <178639833398.1.11785172390991983137.rpms-fedpkg-98556b9e2082@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/fedpkg
Branch : 1.48-1
Commit : 98556b9e2082afc4a12b539b370335e08dbc7a1f
Author : Chenxiong Qi <cqi@redhat.com>
Date : 2018-02-14T23:58:05+08:00
Stats : +40/-1 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/fedpkg/c/98556b9e2082afc4a12b539b370335e08dbc7a1f?branch=1.48-1
Log:
Fix broken syntax in bash completion
A quick fix by backporting patch "fix broken syntax in bash completion".
Signed-off-by: Chenxiong Qi <cqi@redhat.com>
---
diff --git a/0001-fix-broken-syntax-in-bash-completion.patch b/0001-fix-broken-syntax-in-bash-completion.patch
new file mode 100644
index 0000000..a062d0d
--- /dev/null
+++ b/0001-fix-broken-syntax-in-bash-completion.patch
@@ -0,0 +1,34 @@
+From 99b506b6552ba91a91af4b9714d35eb38bae7dbb Mon Sep 17 00:00:00 2001
+From: Todd Zullinger <tmz@pobox.com>
+Date: Wed, 7 Feb 2018 15:42:22 -0500
+Subject: [PATCH] fix broken syntax in bash completion
+
+The completion code added in f7d9b56 ("Port fedrepo-req and
+fedrepo-req-branch to fedpkg", 2017-12-07) missed ';;' separating the
+request-branch and request-repo patterns. Attempting to source the
+bash completion script results in an error:
+
+$ . /usr/share/bash-completion/completions/fedpkg.bash
+-bash: /usr/share/bash-completion/completions/fedpkg.bash: line 196: syntax error near unexpected token `)'
+-bash: /usr/share/bash-completion/completions/fedpkg.bash: line 196: ` request-repo)'
+
+Signed-off-by: Todd Zullinger <tmz@pobox.com>
+---
+ conf/bash-completion/fedpkg.bash | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/conf/bash-completion/fedpkg.bash b/conf/bash-completion/fedpkg.bash
+index 03fa399..f5a0b14 100644
+--- a/conf/bash-completion/fedpkg.bash
++++ b/conf/bash-completion/fedpkg.bash
+@@ -193,6 +193,7 @@ _fedpkg()
+ request-branch)
+ options="--no-git-branch --all-releases"
+ options_string="--sl"
++ ;;
+ request-repo)
+ options="--exception"
+ options_string="--description --monitor --upstreamurl --summary"
+--
+2.14.3
+
diff --git a/fedpkg.spec b/fedpkg.spec
index 2563c56..e3843e1 100644
--- a/fedpkg.spec
+++ b/fedpkg.spec
@@ -5,13 +5,14 @@
Name: fedpkg
Version: 1.31
-Release: 4%{?dist}
+Release: 5%{?dist}
Summary: Fedora utility for working with dist-git
Group: Applications/System
License: GPLv2+
URL: https://pagure.io/fedpkg
Source0: https://pagure.io/releases/fedpkg/%{name}-%{version}.tar.bz2
+Patch0: 0001-fix-broken-syntax-in-bash-completion.patch
# https://pagure.io/fedpkg/pull-request/162
BuildArch: noarch
@@ -71,6 +72,7 @@ Provides the fedpkg command for working with dist-git
%prep
%setup -q
+%patch0 -p1
%build
%{__python} setup.py build
@@ -111,6 +113,9 @@ nosetests
%changelog
+* Wed Feb 14 2018 Chenxiong Qi <cqi@redhat.com> 1.31-5
+- Backport: fix broken syntax in bash completion
+
* Fri Feb 09 2018 Iryna Shcherbina <ishcherb@redhat.com> - 1.31-4
- Update Python 2 dependency declarations to new packaging standards
reply other threads:[~2026-08-10 21:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178639833398.1.11785172390991983137.rpms-fedpkg-98556b9e2082@fedoraproject.org \
--to=cqi@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox